drm/amdgpu/display: fix compiler errors [-Werror,-Wparentheses-equality]

Submitted by Vishwakarma, Pratik on Feb. 4, 2019, 8:16 a.m.

Details

Message ID 20190204081546.24935-1-Pratik.Vishwakarma@amd.com
State Accepted
Commit ba345a0242d7ca7fe841d1926ebc12f2ec3890d8
Headers show
Series "drm/amdgpu/display: fix compiler errors [-Werror,-Wparentheses-equality]" ( rev: 1 ) in AMD X.Org drivers

Not browsing as part of any series.

Commit Message

Vishwakarma, Pratik Feb. 4, 2019, 8:16 a.m. 
Remove extraneous parentheses around the comparison
to silence this warning

Signed-off-by: Pratik Vishwakarma <Pratik.Vishwakarma@amd.com>
---
 drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox 

diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.c b/drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.c
index 7d102ac0d61b..1ef0074302c5 100644
--- a/drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.c
+++ b/drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.c
@@ -63,7 +63,7 @@  void scaler_settings_calculation(struct dcn_bw_internal_vars *v)
 		if (v->interlace_output[k] == 1.0) {
 			v->v_ratio[k] = 2.0 * v->v_ratio[k];
 		}
-		if ((v->underscan_output[k] == 1.0)) {
+		if (v->underscan_output[k] == 1.0) {
 			v->h_ratio[k] = v->h_ratio[k] * v->under_scan_factor;
 			v->v_ratio[k] = v->v_ratio[k] * v->under_scan_factor;
 		}

Comments

Harry Wentland Feb. 5, 2019, 2:43 p.m. 
On 2019-02-04 3:16 a.m., Vishwakarma, Pratik wrote:
> Remove extraneous parentheses around the comparison

> to silence this warning

> 

> Signed-off-by: Pratik Vishwakarma <Pratik.Vishwakarma@amd.com>


Reviewed-by: Harry Wentland <harry.wentland@amd.com>


Harry

> ---

>  drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.c b/drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.c

> index 7d102ac0d61b..1ef0074302c5 100644

> --- a/drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.c

> +++ b/drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_auto.c

> @@ -63,7 +63,7 @@ void scaler_settings_calculation(struct dcn_bw_internal_vars *v)

>  		if (v->interlace_output[k] == 1.0) {

>  			v->v_ratio[k] = 2.0 * v->v_ratio[k];

>  		}

> -		if ((v->underscan_output[k] == 1.0)) {

> +		if (v->underscan_output[k] == 1.0) {

>  			v->h_ratio[k] = v->h_ratio[k] * v->under_scan_factor;

>  			v->v_ratio[k] = v->v_ratio[k] * v->under_scan_factor;

>  		}

>