[6/6] drm/drv: Remove drm_dev_unplug()

Submitted by Noralf Trønnes on Feb. 3, 2019, 3:42 p.m.

Details

Message ID 20190203154200.61479-7-noralf@tronnes.org
State New
Series "drm/drv: Remove drm_dev_unplug()"
Headers show

Commit Message

Noralf Trønnes Feb. 3, 2019, 3:42 p.m.
There are no users left.

Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
---
 drivers/gpu/drm/drm_drv.c | 17 -----------------
 include/drm/drm_drv.h     |  1 -
 2 files changed, 18 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
index e0941200edc6..87210d4a9e53 100644
--- a/drivers/gpu/drm/drm_drv.c
+++ b/drivers/gpu/drm/drm_drv.c
@@ -354,23 +354,6 @@  void drm_dev_exit(int idx)
 }
 EXPORT_SYMBOL(drm_dev_exit);
 
-/**
- * drm_dev_unplug - unplug a DRM device
- * @dev: DRM device
- *
- * This unplugs a hotpluggable DRM device, which makes it inaccessible to
- * userspace operations. Entry-points can use drm_dev_enter() and
- * drm_dev_exit() to protect device resources in a race free manner. This
- * essentially unregisters the device like drm_dev_unregister(), but can be
- * called while there are still open users of @dev.
- */
-void drm_dev_unplug(struct drm_device *dev)
-{
-	drm_dev_unregister(dev);
-	drm_dev_put(dev);
-}
-EXPORT_SYMBOL(drm_dev_unplug);
-
 /*
  * DRM internal mount
  * We want to be able to allocate our own "struct address_space" to control
diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
index c50696c82a42..b8765a6fc092 100644
--- a/include/drm/drm_drv.h
+++ b/include/drm/drm_drv.h
@@ -730,7 +730,6 @@  void drm_dev_put(struct drm_device *dev);
 void drm_put_dev(struct drm_device *dev);
 bool drm_dev_enter(struct drm_device *dev, int *idx);
 void drm_dev_exit(int idx);
-void drm_dev_unplug(struct drm_device *dev);
 
 /**
  * drm_dev_is_unplugged - is a DRM device unplugged

Comments

Oleksandr Andrushchenko Feb. 4, 2019, 10:44 a.m.
On 2/3/19 5:42 PM, Noralf Trønnes wrote:
> There are no users left.

>

> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>

Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>

> ---

>   drivers/gpu/drm/drm_drv.c | 17 -----------------

>   include/drm/drm_drv.h     |  1 -

>   2 files changed, 18 deletions(-)

>

> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c

> index e0941200edc6..87210d4a9e53 100644

> --- a/drivers/gpu/drm/drm_drv.c

> +++ b/drivers/gpu/drm/drm_drv.c

> @@ -354,23 +354,6 @@ void drm_dev_exit(int idx)

>   }

>   EXPORT_SYMBOL(drm_dev_exit);

>   

> -/**

> - * drm_dev_unplug - unplug a DRM device

> - * @dev: DRM device

> - *

> - * This unplugs a hotpluggable DRM device, which makes it inaccessible to

> - * userspace operations. Entry-points can use drm_dev_enter() and

> - * drm_dev_exit() to protect device resources in a race free manner. This

> - * essentially unregisters the device like drm_dev_unregister(), but can be

> - * called while there are still open users of @dev.

> - */

> -void drm_dev_unplug(struct drm_device *dev)

> -{

> -	drm_dev_unregister(dev);

> -	drm_dev_put(dev);

> -}

> -EXPORT_SYMBOL(drm_dev_unplug);

> -

>   /*

>    * DRM internal mount

>    * We want to be able to allocate our own "struct address_space" to control

> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h

> index c50696c82a42..b8765a6fc092 100644

> --- a/include/drm/drm_drv.h

> +++ b/include/drm/drm_drv.h

> @@ -730,7 +730,6 @@ void drm_dev_put(struct drm_device *dev);

>   void drm_put_dev(struct drm_device *dev);

>   bool drm_dev_enter(struct drm_device *dev, int *idx);

>   void drm_dev_exit(int idx);

> -void drm_dev_unplug(struct drm_device *dev);

>   

>   /**

>    * drm_dev_is_unplugged - is a DRM device unplugged
Sean Paul Feb. 7, 2019, 9:08 p.m.
On Sun, Feb 03, 2019 at 04:42:00PM +0100, Noralf Trønnes wrote:
> There are no users left.
> 
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>

Reviewed-by: Sean Paul <sean@poorly.run>

> ---
>  drivers/gpu/drm/drm_drv.c | 17 -----------------
>  include/drm/drm_drv.h     |  1 -
>  2 files changed, 18 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
> index e0941200edc6..87210d4a9e53 100644
> --- a/drivers/gpu/drm/drm_drv.c
> +++ b/drivers/gpu/drm/drm_drv.c
> @@ -354,23 +354,6 @@ void drm_dev_exit(int idx)
>  }
>  EXPORT_SYMBOL(drm_dev_exit);
>  
> -/**
> - * drm_dev_unplug - unplug a DRM device
> - * @dev: DRM device
> - *
> - * This unplugs a hotpluggable DRM device, which makes it inaccessible to
> - * userspace operations. Entry-points can use drm_dev_enter() and
> - * drm_dev_exit() to protect device resources in a race free manner. This
> - * essentially unregisters the device like drm_dev_unregister(), but can be
> - * called while there are still open users of @dev.
> - */
> -void drm_dev_unplug(struct drm_device *dev)
> -{
> -	drm_dev_unregister(dev);
> -	drm_dev_put(dev);
> -}
> -EXPORT_SYMBOL(drm_dev_unplug);
> -
>  /*
>   * DRM internal mount
>   * We want to be able to allocate our own "struct address_space" to control
> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
> index c50696c82a42..b8765a6fc092 100644
> --- a/include/drm/drm_drv.h
> +++ b/include/drm/drm_drv.h
> @@ -730,7 +730,6 @@ void drm_dev_put(struct drm_device *dev);
>  void drm_put_dev(struct drm_device *dev);
>  bool drm_dev_enter(struct drm_device *dev, int *idx);
>  void drm_dev_exit(int idx);
> -void drm_dev_unplug(struct drm_device *dev);
>  
>  /**
>   * drm_dev_is_unplugged - is a DRM device unplugged
> -- 
> 2.20.1
>