[1/6] gallium\auxiliary\vl: Move dirty define to header file

Submitted by Zhu, James on Feb. 1, 2019, 4:28 p.m.

Details

Message ID 1549038496-10500-2-git-send-email-James.Zhu@amd.com
State New
Headers show
Series "Add compute shader support on video compositor render" ( rev: 1 ) in Mesa

Not browsing as part of any series.

Commit Message

Zhu, James Feb. 1, 2019, 4:28 p.m.
Move dirty define to header file to share with compute shader.

Signed-off-by: James Zhu <James.Zhu@amd.com>
---
 src/gallium/auxiliary/vl/vl_compositor.c | 3 ---
 src/gallium/auxiliary/vl/vl_compositor.h | 2 ++
 2 files changed, 2 insertions(+), 3 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/gallium/auxiliary/vl/vl_compositor.c b/src/gallium/auxiliary/vl/vl_compositor.c
index 159a295..2c6d585 100644
--- a/src/gallium/auxiliary/vl/vl_compositor.c
+++ b/src/gallium/auxiliary/vl/vl_compositor.c
@@ -42,9 +42,6 @@ 
 #include "vl_types.h"
 #include "vl_compositor.h"
 
-#define MIN_DIRTY (0)
-#define MAX_DIRTY (1 << 15)
-
 enum VS_OUTPUT
 {
    VS_O_VPOS = 0,
diff --git a/src/gallium/auxiliary/vl/vl_compositor.h b/src/gallium/auxiliary/vl/vl_compositor.h
index 8819176..d51b5f5 100644
--- a/src/gallium/auxiliary/vl/vl_compositor.h
+++ b/src/gallium/auxiliary/vl/vl_compositor.h
@@ -44,6 +44,8 @@  struct pipe_context;
  */
 
 #define VL_COMPOSITOR_MAX_LAYERS 16
+#define MIN_DIRTY (0)
+#define MAX_DIRTY (1 << 15)
 
 /* deinterlace allgorithem */
 enum vl_compositor_deinterlace

Comments

Am 01.02.19 um 17:28 schrieb Zhu, James:
> Move dirty define to header file to share with compute shader.
>
> Signed-off-by: James Zhu <James.Zhu@amd.com>
> ---
>   src/gallium/auxiliary/vl/vl_compositor.c | 3 ---
>   src/gallium/auxiliary/vl/vl_compositor.h | 2 ++
>   2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/src/gallium/auxiliary/vl/vl_compositor.c b/src/gallium/auxiliary/vl/vl_compositor.c
> index 159a295..2c6d585 100644
> --- a/src/gallium/auxiliary/vl/vl_compositor.c
> +++ b/src/gallium/auxiliary/vl/vl_compositor.c
> @@ -42,9 +42,6 @@
>   #include "vl_types.h"
>   #include "vl_compositor.h"
>   
> -#define MIN_DIRTY (0)
> -#define MAX_DIRTY (1 << 15)
> -
>   enum VS_OUTPUT
>   {
>      VS_O_VPOS = 0,
> diff --git a/src/gallium/auxiliary/vl/vl_compositor.h b/src/gallium/auxiliary/vl/vl_compositor.h
> index 8819176..d51b5f5 100644
> --- a/src/gallium/auxiliary/vl/vl_compositor.h
> +++ b/src/gallium/auxiliary/vl/vl_compositor.h
> @@ -44,6 +44,8 @@ struct pipe_context;
>    */
>   
>   #define VL_COMPOSITOR_MAX_LAYERS 16
> +#define MIN_DIRTY (0)
> +#define MAX_DIRTY (1 << 15)

That needs a proper prefix.

E.g. put VL_COMPOSITOR_ in front of the name and rename all usages.

Christian.

>   
>   /* deinterlace allgorithem */
>   enum vl_compositor_deinterlace
On 2019-02-01 11:34 a.m., Christian König wrote:
> Am 01.02.19 um 17:28 schrieb Zhu, James:

>> Move dirty define to header file to share with compute shader.

>>

>> Signed-off-by: James Zhu <James.Zhu@amd.com>

>> ---

>>   src/gallium/auxiliary/vl/vl_compositor.c | 3 ---

>>   src/gallium/auxiliary/vl/vl_compositor.h | 2 ++

>>   2 files changed, 2 insertions(+), 3 deletions(-)

>>

>> diff --git a/src/gallium/auxiliary/vl/vl_compositor.c 

>> b/src/gallium/auxiliary/vl/vl_compositor.c

>> index 159a295..2c6d585 100644

>> --- a/src/gallium/auxiliary/vl/vl_compositor.c

>> +++ b/src/gallium/auxiliary/vl/vl_compositor.c

>> @@ -42,9 +42,6 @@

>>   #include "vl_types.h"

>>   #include "vl_compositor.h"

>>   -#define MIN_DIRTY (0)

>> -#define MAX_DIRTY (1 << 15)

>> -

>>   enum VS_OUTPUT

>>   {

>>      VS_O_VPOS = 0,

>> diff --git a/src/gallium/auxiliary/vl/vl_compositor.h 

>> b/src/gallium/auxiliary/vl/vl_compositor.h

>> index 8819176..d51b5f5 100644

>> --- a/src/gallium/auxiliary/vl/vl_compositor.h

>> +++ b/src/gallium/auxiliary/vl/vl_compositor.h

>> @@ -44,6 +44,8 @@ struct pipe_context;

>>    */

>>     #define VL_COMPOSITOR_MAX_LAYERS 16

>> +#define MIN_DIRTY (0)

>> +#define MAX_DIRTY (1 << 15)

>

> That needs a proper prefix.

>

> E.g. put VL_COMPOSITOR_ in front of the name and rename all usages.

Sure. James
>

> Christian.

>

>>     /* deinterlace allgorithem */

>>   enum vl_compositor_deinterlace

>

> _______________________________________________

> mesa-dev mailing list

> mesa-dev@lists.freedesktop.org

> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
My OCD is really bothered by the backslashes in the commit title. Can
we use forward slashes like all the other commits?
Thanks for point it out!

James

On 2019-02-01 2:33 p.m., Matt Turner wrote:
> My OCD is really bothered by the backslashes in the commit title. Can

> we use forward slashes like all the other commits?