[v2] drm: add definitions for DP Audio/Video compliance tests

Submitted by chandanu@codeaurora.org on Jan. 28, 2019, 10:58 p.m.

Details

Message ID 1548716333-18238-1-git-send-email-chandanu@codeaurora.org
State New
Series "drm: add definitions for DP Audio/Video compliance tests"
Headers show

Commit Message

chandanu@codeaurora.org Jan. 28, 2019, 10:58 p.m.
This change adds definitions needed for DP audio compliance testing.
It also adds missing definition for DP video compliance.

Changes in V2:
-- Delete cover letter for this patch.
-- Move the description from cover letter into patch commit message.
-- Remove DPU from subject prefix

Signed-off-by: Chandan Uddaraju <chandanu@codeaurora.org>
---
 include/drm/drm_dp_helper.h | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Patch hide | download patch | download mbox

diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 5736c94..e688e05 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -556,6 +556,8 @@ 
 # define DP_TEST_LINK_EDID_READ		    (1 << 2)
 # define DP_TEST_LINK_PHY_TEST_PATTERN	    (1 << 3) /* DPCD >= 1.1 */
 # define DP_TEST_LINK_FAUX_PATTERN	    (1 << 4) /* DPCD >= 1.2 */
+# define DP_TEST_LINK_AUDIO_PATTERN         (1 << 5) /* DPCD >= 1.2 */
+# define DP_TEST_LINK_AUDIO_DISABLED_VIDEO  (1 << 6) /* DPCD >= 1.2 */
 
 #define DP_TEST_LINK_RATE		    0x219
 # define DP_LINK_RATE_162		    (0x6)
@@ -604,6 +606,7 @@ 
 # define DP_COLOR_FORMAT_RGB                (0 << 1)
 # define DP_COLOR_FORMAT_YCbCr422           (1 << 1)
 # define DP_COLOR_FORMAT_YCbCr444           (2 << 1)
+# define DP_TEST_DYNAMIC_RANGE_VESA         (0 << 3)
 # define DP_TEST_DYNAMIC_RANGE_CEA          (1 << 3)
 # define DP_TEST_YCBCR_COEFFICIENTS         (1 << 4)
 # define DP_YCBCR_COEFFICIENTS_ITU601       (0 << 4)
@@ -653,6 +656,16 @@ 
 
 #define DP_TEST_SINK			    0x270
 # define DP_TEST_SINK_START		    (1 << 0)
+#define DP_TEST_AUDIO_MODE		    0x271
+#define DP_TEST_AUDIO_PATTERN_TYPE	    0x272
+#define DP_TEST_AUDIO_PERIOD_CH1	    0x273
+#define DP_TEST_AUDIO_PERIOD_CH2	    0x274
+#define DP_TEST_AUDIO_PERIOD_CH3	    0x275
+#define DP_TEST_AUDIO_PERIOD_CH4	    0x276
+#define DP_TEST_AUDIO_PERIOD_CH5	    0x277
+#define DP_TEST_AUDIO_PERIOD_CH6	    0x278
+#define DP_TEST_AUDIO_PERIOD_CH7	    0x279
+#define DP_TEST_AUDIO_PERIOD_CH8	    0x27A
 
 #define DP_FEC_STATUS			    0x280    /* 1.4 */
 # define DP_FEC_DECODE_EN_DETECTED	    (1 << 0)

Comments

Sean Paul Jan. 29, 2019, 3:55 p.m.
On Mon, Jan 28, 2019 at 02:58:53PM -0800, Chandan Uddaraju wrote:
> This change adds definitions needed for DP audio compliance testing.
> It also adds missing definition for DP video compliance.
> 
> Changes in V2:
> -- Delete cover letter for this patch.
> -- Move the description from cover letter into patch commit message.
> -- Remove DPU from subject prefix
> 
> Signed-off-by: Chandan Uddaraju <chandanu@codeaurora.org>

Reviewed-by: Sean Paul <sean@poorly.run>

If no one has any objections, it'd be nice to apply this through msm tree along
with the dpu code that makes use of it.

Sean


> ---
>  include/drm/drm_dp_helper.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 5736c94..e688e05 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -556,6 +556,8 @@
>  # define DP_TEST_LINK_EDID_READ		    (1 << 2)
>  # define DP_TEST_LINK_PHY_TEST_PATTERN	    (1 << 3) /* DPCD >= 1.1 */
>  # define DP_TEST_LINK_FAUX_PATTERN	    (1 << 4) /* DPCD >= 1.2 */
> +# define DP_TEST_LINK_AUDIO_PATTERN         (1 << 5) /* DPCD >= 1.2 */
> +# define DP_TEST_LINK_AUDIO_DISABLED_VIDEO  (1 << 6) /* DPCD >= 1.2 */
>  
>  #define DP_TEST_LINK_RATE		    0x219
>  # define DP_LINK_RATE_162		    (0x6)
> @@ -604,6 +606,7 @@
>  # define DP_COLOR_FORMAT_RGB                (0 << 1)
>  # define DP_COLOR_FORMAT_YCbCr422           (1 << 1)
>  # define DP_COLOR_FORMAT_YCbCr444           (2 << 1)
> +# define DP_TEST_DYNAMIC_RANGE_VESA         (0 << 3)
>  # define DP_TEST_DYNAMIC_RANGE_CEA          (1 << 3)
>  # define DP_TEST_YCBCR_COEFFICIENTS         (1 << 4)
>  # define DP_YCBCR_COEFFICIENTS_ITU601       (0 << 4)
> @@ -653,6 +656,16 @@
>  
>  #define DP_TEST_SINK			    0x270
>  # define DP_TEST_SINK_START		    (1 << 0)
> +#define DP_TEST_AUDIO_MODE		    0x271
> +#define DP_TEST_AUDIO_PATTERN_TYPE	    0x272
> +#define DP_TEST_AUDIO_PERIOD_CH1	    0x273
> +#define DP_TEST_AUDIO_PERIOD_CH2	    0x274
> +#define DP_TEST_AUDIO_PERIOD_CH3	    0x275
> +#define DP_TEST_AUDIO_PERIOD_CH4	    0x276
> +#define DP_TEST_AUDIO_PERIOD_CH5	    0x277
> +#define DP_TEST_AUDIO_PERIOD_CH6	    0x278
> +#define DP_TEST_AUDIO_PERIOD_CH7	    0x279
> +#define DP_TEST_AUDIO_PERIOD_CH8	    0x27A
>  
>  #define DP_FEC_STATUS			    0x280    /* 1.4 */
>  # define DP_FEC_DECODE_EN_DETECTED	    (1 << 0)
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
Daniel Vetter Jan. 29, 2019, 4:43 p.m.
On Tue, Jan 29, 2019 at 10:55:47AM -0500, Sean Paul wrote:
> On Mon, Jan 28, 2019 at 02:58:53PM -0800, Chandan Uddaraju wrote:
> > This change adds definitions needed for DP audio compliance testing.
> > It also adds missing definition for DP video compliance.
> > 
> > Changes in V2:
> > -- Delete cover letter for this patch.
> > -- Move the description from cover letter into patch commit message.
> > -- Remove DPU from subject prefix
> > 
> > Signed-off-by: Chandan Uddaraju <chandanu@codeaurora.org>
> 
> Reviewed-by: Sean Paul <sean@poorly.run>
> 
> If no one has any objections, it'd be nice to apply this through msm tree along
> with the dpu code that makes use of it.

Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> for merging through -msm.
-Daniel

> 
> Sean
> 
> 
> > ---
> >  include/drm/drm_dp_helper.h | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> > index 5736c94..e688e05 100644
> > --- a/include/drm/drm_dp_helper.h
> > +++ b/include/drm/drm_dp_helper.h
> > @@ -556,6 +556,8 @@
> >  # define DP_TEST_LINK_EDID_READ		    (1 << 2)
> >  # define DP_TEST_LINK_PHY_TEST_PATTERN	    (1 << 3) /* DPCD >= 1.1 */
> >  # define DP_TEST_LINK_FAUX_PATTERN	    (1 << 4) /* DPCD >= 1.2 */
> > +# define DP_TEST_LINK_AUDIO_PATTERN         (1 << 5) /* DPCD >= 1.2 */
> > +# define DP_TEST_LINK_AUDIO_DISABLED_VIDEO  (1 << 6) /* DPCD >= 1.2 */
> >  
> >  #define DP_TEST_LINK_RATE		    0x219
> >  # define DP_LINK_RATE_162		    (0x6)
> > @@ -604,6 +606,7 @@
> >  # define DP_COLOR_FORMAT_RGB                (0 << 1)
> >  # define DP_COLOR_FORMAT_YCbCr422           (1 << 1)
> >  # define DP_COLOR_FORMAT_YCbCr444           (2 << 1)
> > +# define DP_TEST_DYNAMIC_RANGE_VESA         (0 << 3)
> >  # define DP_TEST_DYNAMIC_RANGE_CEA          (1 << 3)
> >  # define DP_TEST_YCBCR_COEFFICIENTS         (1 << 4)
> >  # define DP_YCBCR_COEFFICIENTS_ITU601       (0 << 4)
> > @@ -653,6 +656,16 @@
> >  
> >  #define DP_TEST_SINK			    0x270
> >  # define DP_TEST_SINK_START		    (1 << 0)
> > +#define DP_TEST_AUDIO_MODE		    0x271
> > +#define DP_TEST_AUDIO_PATTERN_TYPE	    0x272
> > +#define DP_TEST_AUDIO_PERIOD_CH1	    0x273
> > +#define DP_TEST_AUDIO_PERIOD_CH2	    0x274
> > +#define DP_TEST_AUDIO_PERIOD_CH3	    0x275
> > +#define DP_TEST_AUDIO_PERIOD_CH4	    0x276
> > +#define DP_TEST_AUDIO_PERIOD_CH5	    0x277
> > +#define DP_TEST_AUDIO_PERIOD_CH6	    0x278
> > +#define DP_TEST_AUDIO_PERIOD_CH7	    0x279
> > +#define DP_TEST_AUDIO_PERIOD_CH8	    0x27A
> >  
> >  #define DP_FEC_STATUS			    0x280    /* 1.4 */
> >  # define DP_FEC_DECODE_EN_DETECTED	    (1 << 0)
> > -- 
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> > a Linux Foundation Collaborative Project
> > 
> 
> -- 
> Sean Paul, Software Engineer, Google / Chromium OS
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel