回复:[PATCH 2/2] drm/amdgpu: cleanup setting bulk_movable

Submitted by Zhou, David(ChunMing) on Jan. 28, 2019, 2:28 p.m.

Details

Message ID y6onss13q6r5bt37rx-elaq2ribcbr4-otioln-ewcvotgnzlnkv9z5gipvzk4h-1p4xpiy3cv5d-sgzxrr8oknj1s8lfswe8ab2ouv9wfc-7ul58e-no0uf2npiuyp-aucflq-vqmnck4z7hdya3qj66.1548685719646@email.android.com
State New
Headers show
Series "回复:[PATCH 2/2] drm/amdgpu: cleanup setting bulk_movable" ( rev: 1 ) in AMD X.Org drivers

Not browsing as part of any series.

Commit Message

Zhou, David(ChunMing) Jan. 28, 2019, 2:28 p.m.
Reviewed-by: Chunming Zhou <david1.zhou@amd.com>



send from my phone

-------- 原始邮件 --------
主题:[PATCH 2/2] drm/amdgpu: cleanup setting bulk_movable
发件人:Christian König
收件人:amd-gfx@lists.freedesktop.org
抄送:

We only need to set this to false now when BOs are removed from the LRU.

Signed-off-by: Christian König <christian.koenig@amd.com>

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 ------
 1 file changed, 6 deletions(-)

--
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index a404ac17e5ae..79f9dde70bc0 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -332,7 +332,6 @@  static void amdgpu_vm_bo_base_init(struct amdgpu_vm_bo_base *base,
         if (bo->tbo.resv != vm->root.base.bo->tbo.resv)
                 return;

-       vm->bulk_moveable = false;
         if (bo->tbo.type == ttm_bo_type_kernel)
                 amdgpu_vm_bo_relocated(base);
         else
@@ -698,8 +697,6 @@  int amdgpu_vm_validate_pt_bos(struct amdgpu_device *adev, struct amdgpu_vm *vm,
         struct amdgpu_vm_bo_base *bo_base, *tmp;
         int r = 0;

-       vm->bulk_moveable &= list_empty(&vm->evicted);
-
         list_for_each_entry_safe(bo_base, tmp, &vm->evicted, vm_status) {
                 struct amdgpu_bo *bo = bo_base->bo;

@@ -2775,9 +2772,6 @@  void amdgpu_vm_bo_rmv(struct amdgpu_device *adev,
         struct amdgpu_vm_bo_base **base;

         if (bo) {
-               if (bo->tbo.resv == vm->root.base.bo->tbo.resv)
-                       vm->bulk_moveable = false;
-
                 for (base = &bo_va->base.bo->vm_bo; *base;
                      base = &(*base)->next) {
                         if (*base != &bo_va->base)