[v3,13/42] intel/compiler: lower 16-bit flrp

Submitted by Iago Toral Quiroga on Jan. 15, 2019, 1:53 p.m.

Details

Message ID 20190115135414.2313-14-itoral@igalia.com
State New
Headers show
Series "intel: VK_KHR_shader_float16_int8 implementation" ( rev: 5 4 ) in Mesa

Not browsing as part of any series.

Commit Message

Iago Toral Quiroga Jan. 15, 2019, 1:53 p.m.
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
---
 src/intel/compiler/brw_compiler.c | 1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox

diff --git a/src/intel/compiler/brw_compiler.c b/src/intel/compiler/brw_compiler.c
index f885e79c3e6..04a1a7cac4e 100644
--- a/src/intel/compiler/brw_compiler.c
+++ b/src/intel/compiler/brw_compiler.c
@@ -33,6 +33,7 @@ 
    .lower_sub = true,                                                         \
    .lower_fdiv = true,                                                        \
    .lower_scmp = true,                                                        \
+   .lower_flrp16 = true,                                                      \
    .lower_fmod16 = true,                                                      \
    .lower_fmod32 = true,                                                      \
    .lower_fmod64 = false,                                                     \

Comments

Again, please squash with the previous patch.  Splitting stuff this
granular just makes review harder.

On Tue, Jan 15, 2019 at 7:54 AM Iago Toral Quiroga <itoral@igalia.com>
wrote:

> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
> ---
>  src/intel/compiler/brw_compiler.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/intel/compiler/brw_compiler.c
> b/src/intel/compiler/brw_compiler.c
> index f885e79c3e6..04a1a7cac4e 100644
> --- a/src/intel/compiler/brw_compiler.c
> +++ b/src/intel/compiler/brw_compiler.c
> @@ -33,6 +33,7 @@
>     .lower_sub = true,
>      \
>     .lower_fdiv = true,
>     \
>     .lower_scmp = true,
>     \
> +   .lower_flrp16 = true,
>     \
>     .lower_fmod16 = true,
>     \
>     .lower_fmod32 = true,
>     \
>     .lower_fmod64 = false,
>      \
> --
> 2.17.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
Sorry about that, I split them like this because one change is for NIR
and the other one is for Intel so I thought it was preferred to keep
changes like this in separate patches. Anyway, I understand that for
small changes like this it is not helpful, I'll keep that in mind for
future patches.
On Thu, 2019-01-17 at 14:04 -0600, Jason Ekstrand wrote:
> Again, please squash with the previous patch.  Splitting stuff this
> granular just makes review harder.
> 
> On Tue, Jan 15, 2019 at 7:54 AM Iago Toral Quiroga <itoral@igalia.com
> > wrote:
> > Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
> > 
> > ---
> > 
> >  src/intel/compiler/brw_compiler.c | 1 +
> > 
> >  1 file changed, 1 insertion(+)
> > 
> > 
> > 
> > diff --git a/src/intel/compiler/brw_compiler.c
> > b/src/intel/compiler/brw_compiler.c
> > 
> > index f885e79c3e6..04a1a7cac4e 100644
> > 
> > --- a/src/intel/compiler/brw_compiler.c
> > 
> > +++ b/src/intel/compiler/brw_compiler.c
> > 
> > @@ -33,6 +33,7 @@
> > 
> >     .lower_sub = true,                                             
> >            \
> > 
> >     .lower_fdiv = true,                                           
> >             \
> > 
> >     .lower_scmp = true,                                           
> >             \
> > 
> > +   .lower_flrp16 = true,                                         
> >             \
> > 
> >     .lower_fmod16 = true,                                         
> >             \
> > 
> >     .lower_fmod32 = true,                                         
> >             \
> > 
> >     .lower_fmod64 = false,                                         
> >            \
> >