[v2,5/5] drm/todo: Tick off some tinydrm entries

Submitted by Noralf Trønnes on Jan. 11, 2019, 8:12 p.m.


Message ID 20190111201206.45018-6-noralf@tronnes.org
State Accepted
Commit bd59f2b153af8f387b8fee5cfa5c3084b40b57a0
Headers show
Series "drm/tinydrm: Use damage helper for dirtyfb" ( rev: 6 5 4 3 2 ) in DRI devel

Not browsing as part of any series.

Commit Message

Noralf Trønnes Jan. 11, 2019, 8:12 p.m.
- Better manual-upload support for atomic
  The new damage helper has the necessary pieces to make this work.

- tinydrm_gem_cma_prime_import_sg_table
  This is now moved to the CMA helper and can be set using the

- tinydrm_fb_create
  This is now covered by drm_gem_fb_create_with_dirty()

Cc: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
 Documentation/gpu/todo.rst | 35 -----------------------------------
 1 file changed, 35 deletions(-)

Patch hide | download patch | download mbox

diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index 0a85dad876ae..38360ede1221 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -82,30 +82,6 @@  events for atomic commits correctly. But fixing these bugs is good anyway.
 Contact: Daniel Vetter, respective driver maintainers
-Better manual-upload support for atomic
-This would be especially useful for tinydrm:
-- Add a struct drm_rect dirty_clip to drm_crtc_state. When duplicating the
-  crtc state, clear that to the max values, x/y = 0 and w/h = MAX_INT, in
-  __drm_atomic_helper_crtc_duplicate_state().
-- Move tinydrm_merge_clips into drm_framebuffer.c, dropping the tinydrm\_
-  prefix ofc and using drm_fb\_. drm_framebuffer.c makes sense since this
-  is a function useful to implement the fb->dirty function.
-- Create a new drm_fb_dirty function which does essentially what e.g.
-  mipi_dbi_fb_dirty does. You can use e.g. drm_atomic_helper_update_plane as the
-  template. But instead of doing a simple full-screen plane update, this new
-  helper also sets crtc_state->dirty_clip to the right coordinates. And of
-  course it needs to check whether the fb is actually active (and maybe where),
-  so there's some book-keeping involved. There's also some good fun involved in
-  scaling things appropriately. For that case we might simply give up and
-  declare the entire area covered by the plane as dirty.
-Contact: Noralf Trønnes, Daniel Vetter
 Fallout from atomic KMS
@@ -459,21 +435,10 @@  those drivers as simple as possible, so lots of room for refactoring:
   one of the ideas for having a shared dsi/dbi helper, abstracting away the
   transport details more.
-- tinydrm_gem_cma_prime_import_sg_table should probably go into the cma
-  helpers, as a _vmapped variant (since not every driver needs the vmap).
-  And tinydrm_gem_cma_free_object could the be merged into
-  drm_gem_cma_free_object().
-- tinydrm_fb_create we could move into drm_simple_pipe, only need to add
-  the fb_create hook to drm_simple_pipe_funcs, which would again simplify a
-  bunch of things (since it gives you a one-stop vfunc for simple drivers).
 - Quick aside: The unregister devm stuff is kinda getting the lifetimes of
   a drm_device wrong. Doesn't matter, since everyone else gets it wrong
   too :-)
-- also rework the drm_framebuffer_funcs->dirty hook wire-up, see above.
 Contact: Noralf Trønnes, Daniel Vetter
 AMD DC Display Driver