drm/i915/gvt: Allow F_CMD_ACCESS on mmio 0x21f0

Submitted by Colin Xu on Jan. 11, 2019, 6:25 a.m.

Details

Message ID 20190111062554.16409-1-colin.xu@intel.com
State New
Headers show
Series "drm/i915/gvt: Allow F_CMD_ACCESS on mmio 0x21f0" ( rev: 1 ) in Intel GVT devel

Not browsing as part of any series.

Commit Message

Colin Xu Jan. 11, 2019, 6:25 a.m.
The newly updated guest driver could program 0x21f0 via lri and srm,
without F_CMD_ACCESS flag cmd parser will stop parser reset cmd.
0x21f0 applies to BDW, SKL, KBL, BXT and CFL.

Signed-off-by: Colin Xu <colin.xu@intel.com>
---
 drivers/gpu/drm/i915/gvt/handlers.c | 1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
index 68a62ba5bf54..a4b9659017fd 100644
--- a/drivers/gpu/drm/i915/gvt/handlers.c
+++ b/drivers/gpu/drm/i915/gvt/handlers.c
@@ -2799,6 +2799,7 @@  static int init_broadwell_mmio_info(struct intel_gvt *gvt)
 	MMIO_DFH(_MMIO(0xe2a0), D_BDW_PLUS, F_CMD_ACCESS, NULL, NULL);
 	MMIO_DFH(_MMIO(0xe2b0), D_BDW_PLUS, F_CMD_ACCESS, NULL, NULL);
 	MMIO_DFH(_MMIO(0xe2c0), D_BDW_PLUS, F_CMD_ACCESS, NULL, NULL);
+	MMIO_DFH(_MMIO(0x21f0), D_BDW_PLUS, F_CMD_ACCESS, NULL, NULL);
 	return 0;
 }
 

Comments

Looks good to me.
Reviewed-by: Yan Zhao <yan.y.zhao@intel.com>


> -----Original Message-----

> From: intel-gvt-dev [mailto:intel-gvt-dev-bounces@lists.freedesktop.org] On

> Behalf Of Colin Xu

> Sent: Friday, January 11, 2019 2:26 PM

> To: intel-gvt-dev@lists.freedesktop.org

> Cc: Xu, Colin <colin.xu@intel.com>

> Subject: [PATCH] drm/i915/gvt: Allow F_CMD_ACCESS on mmio 0x21f0

> 

> The newly updated guest driver could program 0x21f0 via lri and srm, without

> F_CMD_ACCESS flag cmd parser will stop parser reset cmd.

> 0x21f0 applies to BDW, SKL, KBL, BXT and CFL.

> 

> Signed-off-by: Colin Xu <colin.xu@intel.com>

> ---

>  drivers/gpu/drm/i915/gvt/handlers.c | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/drivers/gpu/drm/i915/gvt/handlers.c

> b/drivers/gpu/drm/i915/gvt/handlers.c

> index 68a62ba5bf54..a4b9659017fd 100644

> --- a/drivers/gpu/drm/i915/gvt/handlers.c

> +++ b/drivers/gpu/drm/i915/gvt/handlers.c

> @@ -2799,6 +2799,7 @@ static int init_broadwell_mmio_info(struct intel_gvt

> *gvt)

>  	MMIO_DFH(_MMIO(0xe2a0), D_BDW_PLUS, F_CMD_ACCESS, NULL,

> NULL);

>  	MMIO_DFH(_MMIO(0xe2b0), D_BDW_PLUS, F_CMD_ACCESS, NULL,

> NULL);

>  	MMIO_DFH(_MMIO(0xe2c0), D_BDW_PLUS, F_CMD_ACCESS, NULL,

> NULL);

> +	MMIO_DFH(_MMIO(0x21f0), D_BDW_PLUS, F_CMD_ACCESS, NULL,

> NULL);

>  	return 0;

>  }

> 

> --

> 2.20.1

> 

> _______________________________________________

> intel-gvt-dev mailing list

> intel-gvt-dev@lists.freedesktop.org

> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev
On 2019.01.11 14:25:54 +0800, Colin Xu wrote:
> The newly updated guest driver could program 0x21f0 via lri and srm,
> without F_CMD_ACCESS flag cmd parser will stop parser reset cmd.
> 0x21f0 applies to BDW, SKL, KBL, BXT and CFL.
> 
> Signed-off-by: Colin Xu <colin.xu@intel.com>
> ---

Applied, thanks!

>  drivers/gpu/drm/i915/gvt/handlers.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c
> index 68a62ba5bf54..a4b9659017fd 100644
> --- a/drivers/gpu/drm/i915/gvt/handlers.c
> +++ b/drivers/gpu/drm/i915/gvt/handlers.c
> @@ -2799,6 +2799,7 @@ static int init_broadwell_mmio_info(struct intel_gvt *gvt)
>  	MMIO_DFH(_MMIO(0xe2a0), D_BDW_PLUS, F_CMD_ACCESS, NULL, NULL);
>  	MMIO_DFH(_MMIO(0xe2b0), D_BDW_PLUS, F_CMD_ACCESS, NULL, NULL);
>  	MMIO_DFH(_MMIO(0xe2c0), D_BDW_PLUS, F_CMD_ACCESS, NULL, NULL);
> +	MMIO_DFH(_MMIO(0x21f0), D_BDW_PLUS, F_CMD_ACCESS, NULL, NULL);
>  	return 0;
>  }
>  
> -- 
> 2.20.1
> 
> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev