[i-g-t,8/8] tests/fbcon_fbt: Do not print debugfs of features

Submitted by José Roberto de Souza on Jan. 7, 2019, 7:10 p.m.

Details

Message ID 20190107191056.22759-8-jose.souza@intel.com
State New
Series "Series without cover letter"
Headers show

Commit Message

José Roberto de Souza Jan. 7, 2019, 7:10 p.m.
Print the debugfs of the features is only helpful for debug not for
the automated runs, so lets remove it and if needed for debug the one
debugging it can add it back in his/her machine.

Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 tests/kms_fbcon_fbt.c | 27 ++-------------------------
 1 file changed, 2 insertions(+), 25 deletions(-)

Patch hide | download patch | download mbox

diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c
index cdba1c6e..7d1cdd0e 100644
--- a/tests/kms_fbcon_fbt.c
+++ b/tests/kms_fbcon_fbt.c
@@ -105,15 +105,6 @@  static bool connector_can_fbc(drmModeConnectorPtr connector)
 	return true;
 }
 
-static void fbc_print_status(int debugfs_fd)
-{
-	static char buf[128];
-
-	igt_debugfs_simple_read(debugfs_fd, "i915_fbc_status", buf,
-				sizeof(buf));
-	igt_debug("FBC status: %s\n", buf);
-}
-
 static bool fbc_is_enabled(int debugfs_fd)
 {
 	char buf[128];
@@ -125,9 +116,7 @@  static bool fbc_is_enabled(int debugfs_fd)
 
 static bool fbc_wait_until_enabled(int debugfs_fd)
 {
-	bool r = igt_wait(fbc_is_enabled(debugfs_fd), 5000, 1);
-	fbc_print_status(debugfs_fd);
-	return r;
+	return igt_wait(fbc_is_enabled(debugfs_fd), 5000, 1);
 }
 
 static bool fbc_wait_until_update(int debugfs)
@@ -179,21 +168,9 @@  static bool connector_can_psr(drmModeConnectorPtr connector)
 	return (connector->connector_type == DRM_MODE_CONNECTOR_eDP);
 }
 
-static void psr_print_status(int debugfs_fd)
-{
-	static char buf[PSR_STATUS_MAX_LEN];
-
-	igt_debugfs_simple_read(debugfs_fd, "i915_edp_psr_status", buf,
-				sizeof(buf));
-	igt_debug("PSR status: %s\n", buf);
-}
-
 static bool psr_wait_until_enabled(int debugfs_fd)
 {
-	bool r = psr_wait_entry(debugfs_fd);
-
-	psr_print_status(debugfs_fd);
-	return r;
+	return psr_wait_entry(debugfs_fd);
 }
 
 static bool psr_wait_until_update(int debugfs_fd)

Comments

Chris Wilson Jan. 7, 2019, 8:44 p.m.
Quoting José Roberto de Souza (2019-01-07 19:10:56)
> Print the debugfs of the features is only helpful for debug not for
> the automated runs, so lets remove it and if needed for debug the one
> debugging it can add it back in his/her machine.

In the automated runs, having the debug information for a failure seems
even more useful (especially for sporadic, hard to reproduce failures).
Is that status (and so clues as to what failed) printed on failure? 
-Chris