[DPU,v1] drm/msm/dpu: Change RGB565 and BGR565 format map.

Submitted by Tanmay Shah on Dec. 14, 2018, 6:23 p.m.

Details

Message ID 20181214182340.1195-1-tanmay@codeaurora.org
State New
Headers show
Series "drm/msm/dpu: Change RGB565 and BGR565 format map." ( rev: 1 ) in Freedreno

Not browsing as part of any series.

Commit Message

Tanmay Shah Dec. 14, 2018, 6:23 p.m.
Red and Blue colors will be interchanged on display with
current format maps for RGB565 and BGR565.

Change both format maps to dispaly correct colors.

Signed-off-by: Tanmay Shah <tanmay@codeaurora.org>
---
 drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
index d53abc8ce670..f59fe1a9f4b9 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
@@ -263,13 +263,13 @@  static const struct dpu_format dpu_format_map[] = {
 
 	INTERLEAVED_RGB_FMT(RGB565,
 		0, COLOR_5BIT, COLOR_6BIT, COLOR_5BIT,
-		C1_B_Cb, C0_G_Y, C2_R_Cr, 0, 3,
+		C2_R_Cr, C0_G_Y, C1_B_Cb, 0, 3,
 		false, 2, 0,
 		DPU_FETCH_LINEAR, 1),
 
 	INTERLEAVED_RGB_FMT(BGR565,
 		0, COLOR_5BIT, COLOR_6BIT, COLOR_5BIT,
-		C2_R_Cr, C0_G_Y, C1_B_Cb, 0, 3,
+		C1_B_Cb, C0_G_Y, C2_R_Cr, 0, 3,
 		false, 2, 0,
 		DPU_FETCH_LINEAR, 1),
 

Comments

On 2018-12-14 23:53, Tanmay Shah wrote:
> Red and Blue colors will be interchanged on display with
> current format maps for RGB565 and BGR565.
> 
> Change both format maps to dispaly correct colors.
> 
> Signed-off-by: Tanmay Shah <tanmay@codeaurora.org>

LGTM.

Reviewed-by: Jayant Shekhar <jshekhar@codeaurora.org>

> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
> index d53abc8ce670..f59fe1a9f4b9 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
> @@ -263,13 +263,13 @@ static const struct dpu_format dpu_format_map[] = 
> {
> 
>  	INTERLEAVED_RGB_FMT(RGB565,
>  		0, COLOR_5BIT, COLOR_6BIT, COLOR_5BIT,
> -		C1_B_Cb, C0_G_Y, C2_R_Cr, 0, 3,
> +		C2_R_Cr, C0_G_Y, C1_B_Cb, 0, 3,
>  		false, 2, 0,
>  		DPU_FETCH_LINEAR, 1),
> 
>  	INTERLEAVED_RGB_FMT(BGR565,
>  		0, COLOR_5BIT, COLOR_6BIT, COLOR_5BIT,
> -		C2_R_Cr, C0_G_Y, C1_B_Cb, 0, 3,
> +		C1_B_Cb, C0_G_Y, C2_R_Cr, 0, 3,
>  		false, 2, 0,
>  		DPU_FETCH_LINEAR, 1),
On 2018-12-15 00:04, jshekhar@codeaurora.org wrote:
> On 2018-12-14 23:53, Tanmay Shah wrote:
>> Red and Blue colors will be interchanged on display with
>> current format maps for RGB565 and BGR565.
>> 
>> Change both format maps to dispaly correct colors.
>> 

spelling: dispaly/display

>> Signed-off-by: Tanmay Shah <tanmay@codeaurora.org>
> 
> LGTM.
> 
> Reviewed-by: Jayant Shekhar <jshekhar@codeaurora.org>
> 
>> ---
>>  drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
>> b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
>> index d53abc8ce670..f59fe1a9f4b9 100644
>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
>> @@ -263,13 +263,13 @@ static const struct dpu_format dpu_format_map[] 
>> = {
>> 
>>  	INTERLEAVED_RGB_FMT(RGB565,
>>  		0, COLOR_5BIT, COLOR_6BIT, COLOR_5BIT,
>> -		C1_B_Cb, C0_G_Y, C2_R_Cr, 0, 3,
>> +		C2_R_Cr, C0_G_Y, C1_B_Cb, 0, 3,
>>  		false, 2, 0,
>>  		DPU_FETCH_LINEAR, 1),
>> 
>>  	INTERLEAVED_RGB_FMT(BGR565,
>>  		0, COLOR_5BIT, COLOR_6BIT, COLOR_5BIT,
>> -		C2_R_Cr, C0_G_Y, C1_B_Cb, 0, 3,
>> +		C1_B_Cb, C0_G_Y, C2_R_Cr, 0, 3,
>>  		false, 2, 0,
>>  		DPU_FETCH_LINEAR, 1),
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel