[2/2] arm64: dts: sdm845: Add interconnect for GPU

Submitted by Jordan Crouse on Dec. 13, 2018, 5:31 p.m.

Details

Message ID 20181213173149.6975-3-jcrouse@codeaurora.org
State New
Headers show
Series "arm64: dts: sdm845: Add sdm845 GPU interconnect" ( rev: 1 ) in Freedreno

Not browsing as part of any series.

Commit Message

Jordan Crouse Dec. 13, 2018, 5:31 p.m.
Define an interconnect port for the GPU to set bus
capabilities.

Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 3 +++
 1 file changed, 3 insertions(+)

Patch hide | download patch | download mbox

diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 0a5ddfc4c59b..9323f211ca40 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -1370,6 +1370,9 @@ 
 
 			operating-points-v2 = <&gpu_opp_table>;
 
+			interconnects = <&qnoc MASTER_GFX3D &qnoc SLAVE_EBI1>;
+			interconnect-names = "gfx-mem";
+
 			qcom,gmu = <&gmu>;
 
 			gpu_opp_table: opp-table {

Comments

Hi,

On Thu, Dec 13, 2018 at 9:32 AM Jordan Crouse <jcrouse@codeaurora.org> wrote:
>
> Define an interconnect port for the GPU to set bus
> capabilities.
>
> Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 0a5ddfc4c59b..9323f211ca40 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -1370,6 +1370,9 @@
>
>                         operating-points-v2 = <&gpu_opp_table>;
>
> +                       interconnects = <&qnoc MASTER_GFX3D &qnoc SLAVE_EBI1>;
> +                       interconnect-names = "gfx-mem";

Thanks for sending this patch.  Unfortunately the interconnect node is
not called "qnoc" anymore.  It's called "&rsc_hlos" in v12 of Georgi's
patchset:

https://lkml.kernel.org/r/20181208170216.32555-7-georgi.djakov@linaro.org

Can you repost with that fix (the bindings patch should be updated
too)?  Other than that feel feel free to add my Reviewed-by to this
patch.

Thanks!


-Doug