[v2,14/14] drivers/video: Constantify function argument for HDMI infoframe log

Submitted by Shankar, Uma on Dec. 11, 2018, 8:38 p.m.

Details

Message ID 1544560702-16447-15-git-send-email-uma.shankar@intel.com
State New
Headers show
Series "Add HDR Metadata Parsing and handling in DRM layer" ( rev: 2 ) in DRI devel

Browsing this patch as part of:
"Add HDR Metadata Parsing and handling in DRM layer" rev 2 in DRI devel
<< prev patch [14/14] next patch >>

Commit Message

Shankar, Uma Dec. 11, 2018, 8:38 p.m.
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Function argument for hdmi_drm_infoframe_log is made constant.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
---
 drivers/video/hdmi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c
index 0937c8c..7ab8086 100644
--- a/drivers/video/hdmi.c
+++ b/drivers/video/hdmi.c
@@ -1383,8 +1383,8 @@  static void hdmi_audio_infoframe_log(const char *level,
  * @frame: HDMI DRM infoframe
  */
 static void hdmi_drm_infoframe_log(const char *level,
-                                  struct device *dev,
-                                  struct hdmi_drm_infoframe *frame)
+				   struct device *dev,
+				   const struct hdmi_drm_infoframe *frame)
 {
 	int i;
 

Comments

Regards

Shashank


On 12/12/2018 2:08 AM, Uma Shankar wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Function argument for hdmi_drm_infoframe_log is made constant.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> ---
>   drivers/video/hdmi.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c
> index 0937c8c..7ab8086 100644
> --- a/drivers/video/hdmi.c
> +++ b/drivers/video/hdmi.c
> @@ -1383,8 +1383,8 @@ static void hdmi_audio_infoframe_log(const char *level,
>    * @frame: HDMI DRM infoframe
>    */
>   static void hdmi_drm_infoframe_log(const char *level,
> -                                  struct device *dev,
> -                                  struct hdmi_drm_infoframe *frame)
> +				   struct device *dev,
> +				   const struct hdmi_drm_infoframe *frame)
Why not merge this patch with 8/14 drm: Enable HDR infoframe support ?
- Shashank
>   {
>   	int i;
>
>-----Original Message-----

>From: dri-devel [mailto:dri-devel-bounces@lists.freedesktop.org] On Behalf Of

>Sharma, Shashank

>Sent: Friday, December 21, 2018 2:28 PM

>To: Shankar, Uma <uma.shankar@intel.com>; intel-gfx@lists.freedesktop.org;

>dri-devel@lists.freedesktop.org

>Cc: Syrjala, Ville <ville.syrjala@intel.com>; Lankhorst, Maarten

><maarten.lankhorst@intel.com>

>Subject: Re: [v2 14/14] drivers/video: Constantify function argument for HDMI

>infoframe log

>

>Regards

>

>Shashank

>

>

>On 12/12/2018 2:08 AM, Uma Shankar wrote:

>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>

>>

>> Function argument for hdmi_drm_infoframe_log is made constant.

>>

>> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

>> Signed-off-by: Uma Shankar <uma.shankar@intel.com>

>> ---

>>   drivers/video/hdmi.c | 4 ++--

>>   1 file changed, 2 insertions(+), 2 deletions(-)

>>

>> diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c index

>> 0937c8c..7ab8086 100644

>> --- a/drivers/video/hdmi.c

>> +++ b/drivers/video/hdmi.c

>> @@ -1383,8 +1383,8 @@ static void hdmi_audio_infoframe_log(const char

>*level,

>>    * @frame: HDMI DRM infoframe

>>    */

>>   static void hdmi_drm_infoframe_log(const char *level,

>> -                                  struct device *dev,

>> -                                  struct hdmi_drm_infoframe *frame)

>> +				   struct device *dev,

>> +				   const struct hdmi_drm_infoframe *frame)

>Why not merge this patch with 8/14 drm: Enable HDR infoframe support ?


Will update this.

Thanks Shashank for the review and valuable comments.

Regards,
Uma Shankar
>- Shashank

>>   {

>>   	int i;

>>

>

>_______________________________________________

>dri-devel mailing list

>dri-devel@lists.freedesktop.org

>https://lists.freedesktop.org/mailman/listinfo/dri-devel