[v2,05/14] drm/i915: Attach HDR metadata property to connector

Submitted by Shankar, Uma on Dec. 11, 2018, 8:38 p.m.

Details

Message ID 1544560702-16447-6-git-send-email-uma.shankar@intel.com
State New
Headers show
Series "Add HDR Metadata Parsing and handling in DRM layer" ( rev: 2 ) in DRI devel

Commit Message

Shankar, Uma Dec. 11, 2018, 8:38 p.m.
Attach HDR metadata property to connector object.

v2: Rebase

Signed-off-by: Uma Shankar <uma.shankar@intel.com>
---
 drivers/gpu/drm/i915/intel_hdmi.c | 2 ++
 1 file changed, 2 insertions(+)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index 07e803a..8a1e5cb 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -2154,6 +2154,8 @@  static void intel_hdmi_destroy(struct drm_connector *connector)
 	intel_attach_aspect_ratio_property(connector);
 	drm_connector_attach_content_type_property(connector);
 	connector->state->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;
+	drm_object_attach_property(&connector->base,
+		connector->dev->mode_config.hdr_source_metadata_property, 0);
 
 	if (!HAS_GMCH_DISPLAY(dev_priv))
 		drm_connector_attach_max_bpc_property(connector, 8, 12);

Comments

Regards

Shashank


On 12/12/2018 2:08 AM, Uma Shankar wrote:
> Attach HDR metadata property to connector object.
>
> v2: Rebase
>
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> ---
>   drivers/gpu/drm/i915/intel_hdmi.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index 07e803a..8a1e5cb 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -2154,6 +2154,8 @@ static void intel_hdmi_destroy(struct drm_connector *connector)
>   	intel_attach_aspect_ratio_property(connector);
>   	drm_connector_attach_content_type_property(connector);
>   	connector->state->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;
> +	drm_object_attach_property(&connector->base,
> +		connector->dev->mode_config.hdr_source_metadata_property, 0);
Alignment with line above missing.
- Shashank
>   
>   	if (!HAS_GMCH_DISPLAY(dev_priv))
>   		drm_connector_attach_max_bpc_property(connector, 8, 12);
>-----Original Message-----
>From: Sharma, Shashank
>Sent: Thursday, December 20, 2018 11:56 PM
>To: Shankar, Uma <uma.shankar@intel.com>; intel-gfx@lists.freedesktop.org;
>dri-devel@lists.freedesktop.org
>Cc: Lankhorst, Maarten <maarten.lankhorst@intel.com>; Syrjala, Ville
><ville.syrjala@intel.com>; Brian.Starkey@arm.com
>Subject: Re: [v2 05/14] drm/i915: Attach HDR metadata property to connector
>
>Regards
>
>Shashank
>
>
>On 12/12/2018 2:08 AM, Uma Shankar wrote:
>> Attach HDR metadata property to connector object.
>>
>> v2: Rebase
>>
>> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
>> ---
>>   drivers/gpu/drm/i915/intel_hdmi.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c
>b/drivers/gpu/drm/i915/intel_hdmi.c
>> index 07e803a..8a1e5cb 100644
>> --- a/drivers/gpu/drm/i915/intel_hdmi.c
>> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
>> @@ -2154,6 +2154,8 @@ static void intel_hdmi_destroy(struct drm_connector
>*connector)
>>   	intel_attach_aspect_ratio_property(connector);
>>   	drm_connector_attach_content_type_property(connector);
>>   	connector->state->picture_aspect_ratio =
>HDMI_PICTURE_ASPECT_NONE;
>> +	drm_object_attach_property(&connector->base,
>> +		connector->dev->mode_config.hdr_source_metadata_property,
>0);
>Alignment with line above missing.

It's just to keep it within 80 characters. Hope this is ok. Not sure whether this
alignment or 80 character limit takes more priority. 

Regards,
Uma Shankar

>- Shashank
>>
>>   	if (!HAS_GMCH_DISPLAY(dev_priv))
>>   		drm_connector_attach_max_bpc_property(connector, 8, 12);