[1/3] drm/i915: Remove a very stale FIXME

Submitted by Matt Roper on Dec. 6, 2018, 5:09 p.m.

Details

Message ID 20181206170944.16539-2-matthew.d.roper@intel.com
State New
Series "New DDB allocation algorithm"
Headers show

Commit Message

Matt Roper Dec. 6, 2018, 5:09 p.m.
SKL watermark calculations can and do trigger atomic transaction
rejection if no valid set of watermarks can be found.  This FIXME
comment in the code hasn't been relevant for a very long time.

Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 4 ----
 1 file changed, 4 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index a26b4eddda25..9500bda64f26 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -5548,10 +5548,6 @@  skl_compute_wm(struct drm_atomic_state *state)
 	 * Note that the DDB allocation above may have added more CRTC's that
 	 * weren't otherwise being modified (and set bits in dirty_pipes) if
 	 * pipe allocations had to change.
-	 *
-	 * FIXME:  Now that we're doing this in the atomic check phase, we
-	 * should allow skl_update_pipe_wm() to return failure in cases where
-	 * no suitable watermark values can be found.
 	 */
 	for_each_new_crtc_in_state(state, crtc, cstate, i) {
 		struct intel_crtc_state *intel_cstate =

Comments

Ville Syrjälä Dec. 10, 2018, 7:34 p.m.
On Thu, Dec 06, 2018 at 09:09:42AM -0800, Matt Roper wrote:
> SKL watermark calculations can and do trigger atomic transaction
> rejection if no valid set of watermarks can be found.  This FIXME
> comment in the code hasn't been relevant for a very long time.

Identical patch already pushed.

> 
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_pm.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index a26b4eddda25..9500bda64f26 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -5548,10 +5548,6 @@ skl_compute_wm(struct drm_atomic_state *state)
>  	 * Note that the DDB allocation above may have added more CRTC's that
>  	 * weren't otherwise being modified (and set bits in dirty_pipes) if
>  	 * pipe allocations had to change.
> -	 *
> -	 * FIXME:  Now that we're doing this in the atomic check phase, we
> -	 * should allow skl_update_pipe_wm() to return failure in cases where
> -	 * no suitable watermark values can be found.
>  	 */
>  	for_each_new_crtc_in_state(state, crtc, cstate, i) {
>  		struct intel_crtc_state *intel_cstate =
> -- 
> 2.14.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx