[3/3] drm/i915: Restore Braswell GGTT update w/a

Submitted by Chris Wilson on Dec. 5, 2018, 2:40 p.m.

Details

Message ID 20181205144051.10619-3-chris@chris-wilson.co.uk
State New
Headers show
Series "Series without cover letter" ( rev: 1 ) in Intel GFX - Try Bot

Browsing this patch as part of:
"Series without cover letter" rev 1 in Intel GFX - Try Bot
<< prev patch [3/3] next patch >>

Commit Message

Chris Wilson Dec. 5, 2018, 2:40 p.m.
Instability while running gem_concurrent_blit (both invalid results and
GPU hangs) is being hit once again on Braswell. So presumably the earlier
problem never went away but was hidden instead, so restore the w/a.

Testcase: igt/gem_concurrent_blit
Fixes: 4509276ee824 ("drm/i915: Remove Braswell GGTT update w/a")
References: 5bab6f60cb4d ("drm/i915: Serialise updates to GGTT with access through GGTT on Braswell")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: <stable@vger.kernel.org> # v4.12+
---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 62bde517d383..4022521cd39a 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -3353,7 +3353,8 @@  static int gen8_gmch_probe(struct i915_ggtt *ggtt)
 	ggtt->vm.insert_entries = gen8_ggtt_insert_entries;
 
 	/* Serialize GTT updates with aperture access on BXT if VT-d is on. */
-	if (intel_ggtt_update_needs_vtd_wa(dev_priv)) {
+	if (IS_CHERRYVIEW(dev_priv) ||
+	    intel_ggtt_update_needs_vtd_wa(dev_priv)) {
 		ggtt->vm.insert_entries = bxt_vtd_ggtt_insert_entries__BKL;
 		ggtt->vm.insert_page    = bxt_vtd_ggtt_insert_page__BKL;
 		if (ggtt->vm.clear_range != nop_clear_range)