[v2] drm/i915/gvt: Fix tiled memory decoding bug on BDW

Submitted by Zhang, Tina on Dec. 3, 2018, 8:29 a.m.

Details

Message ID 1543825763-4118-1-git-send-email-tina.zhang@intel.com
State New
Headers show
Series "drm/i915/gvt: Fix tiled memory decoding bug on BDW" ( rev: 1 ) in Intel GVT devel

Not browsing as part of any series.

Commit Message

Zhang, Tina Dec. 3, 2018, 8:29 a.m.
Commit b244ffa15c8b ("drm/i915/gvt: Fix drm_format_mod value for vGPU
plane") introduced a regression issue to the tiled memory decoding on BDW.

This patch can fix this issue.

Here is the issue detail: https://github.com/intel/gvt-linux/issues/61

v1->v2:
- Refine the commit message. (Zhenyu)

Fixes: b244ffa15c8b("drm/i915/gvt: Fix drm_format_mod value for vGPU plane")
Signed-off-by: Tina Zhang <tina.zhang@intel.com>
Cc: stable@vger.kernel.org # v4.19+
Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
---
 drivers/gpu/drm/i915/gvt/fb_decoder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/gvt/fb_decoder.c b/drivers/gpu/drm/i915/gvt/fb_decoder.c
index 481896f..85e6736 100644
--- a/drivers/gpu/drm/i915/gvt/fb_decoder.c
+++ b/drivers/gpu/drm/i915/gvt/fb_decoder.c
@@ -235,7 +235,7 @@  int intel_vgpu_decode_primary_plane(struct intel_vgpu *vgpu,
 		plane->bpp = skl_pixel_formats[fmt].bpp;
 		plane->drm_format = skl_pixel_formats[fmt].drm_format;
 	} else {
-		plane->tiled = !!(val & DISPPLANE_TILED);
+		plane->tiled = val & DISPPLANE_TILED;
 		fmt = bdw_format_to_drm(val & DISPPLANE_PIXFORMAT_MASK);
 		plane->bpp = bdw_pixel_formats[fmt].bpp;
 		plane->drm_format = bdw_pixel_formats[fmt].drm_format;

Comments

On 2018.12.03 16:29:23 +0800, Tina Zhang wrote:
> Commit b244ffa15c8b ("drm/i915/gvt: Fix drm_format_mod value for vGPU
> plane") introduced a regression issue to the tiled memory decoding on BDW.
> 
> This patch can fix this issue.
> 
> Here is the issue detail: https://github.com/intel/gvt-linux/issues/61
> 
> v1->v2:
> - Refine the commit message. (Zhenyu)
> 
> Fixes: b244ffa15c8b("drm/i915/gvt: Fix drm_format_mod value for vGPU plane")
> Signed-off-by: Tina Zhang <tina.zhang@intel.com>
> Cc: stable@vger.kernel.org # v4.19+
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/gvt/fb_decoder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/fb_decoder.c b/drivers/gpu/drm/i915/gvt/fb_decoder.c
> index 481896f..85e6736 100644
> --- a/drivers/gpu/drm/i915/gvt/fb_decoder.c
> +++ b/drivers/gpu/drm/i915/gvt/fb_decoder.c
> @@ -235,7 +235,7 @@ int intel_vgpu_decode_primary_plane(struct intel_vgpu *vgpu,
>  		plane->bpp = skl_pixel_formats[fmt].bpp;
>  		plane->drm_format = skl_pixel_formats[fmt].drm_format;
>  	} else {
> -		plane->tiled = !!(val & DISPPLANE_TILED);
> +		plane->tiled = val & DISPPLANE_TILED;
>  		fmt = bdw_format_to_drm(val & DISPPLANE_PIXFORMAT_MASK);
>  		plane->bpp = bdw_pixel_formats[fmt].bpp;
>  		plane->drm_format = bdw_pixel_formats[fmt].drm_format;
> -- 
> 2.7.4
>

Applied. Thanks!