i915/dp/fec: Fix static check warning

Submitted by Srivatsa, Anusha on Nov. 30, 2018, 11:14 p.m.

Details

Message ID 20181130231428.7156-1-anusha.srivatsa@intel.com
State New
Headers show
Series "i915/dp/fec: Fix static check warning" ( rev: 1 ) in Intel GFX

Not browsing as part of any series.

Commit Message

Srivatsa, Anusha Nov. 30, 2018, 11:14 p.m.
From: Anusha Srivatsa <anusha.srivatsa@intel.com>

Fix indentation error in the commit:
commit 08cadae8e157 ("i915/dp/fec: Cache the FEC_CAPABLE DPCD register")

Fixes: 08cadae8e157 ("i915/dp/fec: Cache the FEC_CAPABLE DPCD register")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 38a6e82153fd..8fa28342cfe3 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -4032,8 +4032,8 @@  static void intel_dp_get_dsc_sink_cap(struct intel_dp *intel_dp)
 					      &intel_dp->fec_capable) < 0)
 				DRM_ERROR("Failed to read FEC DPCD register\n");
 
-		DRM_DEBUG_KMS("FEC CAPABILITY: %x\n",
-			      intel_dp->fec_capable);
+			DRM_DEBUG_KMS("FEC CAPABILITY: %x\n",
+				      intel_dp->fec_capable);
 		}
 	}
 }

Comments

On Fri, Nov 30, 2018 at 03:14:28PM -0800, Anusha wrote:
> From: Anusha Srivatsa <anusha.srivatsa@intel.com>
> 
> Fix indentation error in the commit:
> commit 08cadae8e157 ("i915/dp/fec: Cache the FEC_CAPABLE DPCD register")
> 
> Fixes: 08cadae8e157 ("i915/dp/fec: Cache the FEC_CAPABLE DPCD register")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>

thanks for the report and patch.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_dp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 38a6e82153fd..8fa28342cfe3 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -4032,8 +4032,8 @@ static void intel_dp_get_dsc_sink_cap(struct intel_dp *intel_dp)
>  					      &intel_dp->fec_capable) < 0)
>  				DRM_ERROR("Failed to read FEC DPCD register\n");
>  
> -		DRM_DEBUG_KMS("FEC CAPABILITY: %x\n",
> -			      intel_dp->fec_capable);
> +			DRM_DEBUG_KMS("FEC CAPABILITY: %x\n",
> +				      intel_dp->fec_capable);
>  		}
>  	}
>  }
> -- 
> 2.19.1
>
Quoting Anusha (2018-11-30 23:14:28)
> From: Anusha Srivatsa <anusha.srivatsa@intel.com>
> 
> Fix indentation error in the commit:
> commit 08cadae8e157 ("i915/dp/fec: Cache the FEC_CAPABLE DPCD register")
> 
> Fixes: 08cadae8e157 ("i915/dp/fec: Cache the FEC_CAPABLE DPCD register")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_dp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 38a6e82153fd..8fa28342cfe3 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -4032,8 +4032,8 @@ static void intel_dp_get_dsc_sink_cap(struct intel_dp *intel_dp)
>                                               &intel_dp->fec_capable) < 0)
>                                 DRM_ERROR("Failed to read FEC DPCD register\n");
>  
> -               DRM_DEBUG_KMS("FEC CAPABILITY: %x\n",
> -                             intel_dp->fec_capable);
> +                       DRM_DEBUG_KMS("FEC CAPABILITY: %x\n",
> +                                     intel_dp->fec_capable);

I suggested it was useful to know !FEC CAPABILITY. If you are going to
print debug info, might as well show it all.
https://patchwork.freedesktop.org/patch/263060/
-Chris