drm/i915/gvt: Fixed tiled memory decoding bug on BDW

Submitted by Zhang, Tina on Nov. 30, 2018, 3:51 a.m.

Details

Message ID 1543549885-4029-1-git-send-email-tina.zhang@intel.com
State New
Series "drm/i915/gvt: Fixed tiled memory decoding bug on BDW"
Headers show

Commit Message

Zhang, Tina Nov. 30, 2018, 3:51 a.m.
This is a regression issue caused by commit b244ffa15c8b
("drm/i915/gvt: Fix drm_format_mod value for vGPU plane")

This patch can fix the issue https://github.com/intel/gvt-linux/issues/61

Signed-off-by: Tina Zhang <tina.zhang@intel.com>
Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
---
 drivers/gpu/drm/i915/gvt/fb_decoder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/gvt/fb_decoder.c b/drivers/gpu/drm/i915/gvt/fb_decoder.c
index 481896f..85e6736 100644
--- a/drivers/gpu/drm/i915/gvt/fb_decoder.c
+++ b/drivers/gpu/drm/i915/gvt/fb_decoder.c
@@ -235,7 +235,7 @@  int intel_vgpu_decode_primary_plane(struct intel_vgpu *vgpu,
 		plane->bpp = skl_pixel_formats[fmt].bpp;
 		plane->drm_format = skl_pixel_formats[fmt].drm_format;
 	} else {
-		plane->tiled = !!(val & DISPPLANE_TILED);
+		plane->tiled = val & DISPPLANE_TILED;
 		fmt = bdw_format_to_drm(val & DISPPLANE_PIXFORMAT_MASK);
 		plane->bpp = bdw_pixel_formats[fmt].bpp;
 		plane->drm_format = bdw_pixel_formats[fmt].drm_format;

Comments

Zhenyu Wang Nov. 30, 2018, 3:50 a.m.
On 2018.11.30 11:51:25 +0800, Tina Zhang wrote:
> This is a regression issue caused by commit b244ffa15c8b
> ("drm/i915/gvt: Fix drm_format_mod value for vGPU plane")
> 
> This patch can fix the issue https://github.com/intel/gvt-linux/issues/61
> 
> Signed-off-by: Tina Zhang <tina.zhang@intel.com>
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/gvt/fb_decoder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/fb_decoder.c b/drivers/gpu/drm/i915/gvt/fb_decoder.c
> index 481896f..85e6736 100644
> --- a/drivers/gpu/drm/i915/gvt/fb_decoder.c
> +++ b/drivers/gpu/drm/i915/gvt/fb_decoder.c
> @@ -235,7 +235,7 @@ int intel_vgpu_decode_primary_plane(struct intel_vgpu *vgpu,
>  		plane->bpp = skl_pixel_formats[fmt].bpp;
>  		plane->drm_format = skl_pixel_formats[fmt].drm_format;
>  	} else {
> -		plane->tiled = !!(val & DISPPLANE_TILED);
> +		plane->tiled = val & DISPPLANE_TILED;
>  		fmt = bdw_format_to_drm(val & DISPPLANE_PIXFORMAT_MASK);
>  		plane->bpp = bdw_pixel_formats[fmt].bpp;
>  		plane->drm_format = bdw_pixel_formats[fmt].drm_format;
> -- 

oh, sorry that forgot to update on BDW part. Could you provide the
Fixes: line and better cc kernel stable?

thanks