drm/i915/ddi: Check for unexpectedly disabled transcoders

Submitted by Imre Deak on Nov. 29, 2018, 3:40 p.m.

Details

Message ID 20181129154051.21896-1-imre.deak@intel.com
State New
Headers show
Series "drm/i915/ddi: Check for unexpectedly disabled transcoders" ( rev: 1 ) in Intel GFX

Not browsing as part of any series.

Commit Message

Imre Deak Nov. 29, 2018, 3:40 p.m.
The DDI eDP/pipe A/B/C transcoders must be enabled whenever we observe
the DDI buffer of the port connected to them to be enabled (via
DDI_BUF_CTL). Add a consistency check for this to the HW readout code of
these transcoders.

Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/intel_ddi.c | 4 ++++
 1 file changed, 4 insertions(+)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index ad11540ac436..0476d1d33bfb 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -2029,6 +2029,8 @@  static void intel_ddi_get_encoder_pipes(struct intel_encoder *encoder,
 	if (port == PORT_A) {
 		tmp = I915_READ(TRANS_DDI_FUNC_CTL(TRANSCODER_EDP));
 
+		WARN_ON(!(tmp & TRANS_DDI_FUNC_ENABLE));
+
 		switch (tmp & TRANS_DDI_EDP_INPUT_MASK) {
 		default:
 			MISSING_CASE(tmp & TRANS_DDI_EDP_INPUT_MASK);
@@ -2057,6 +2059,8 @@  static void intel_ddi_get_encoder_pipes(struct intel_encoder *encoder,
 		if ((tmp & TRANS_DDI_PORT_MASK) != TRANS_DDI_SELECT_PORT(port))
 			continue;
 
+		WARN_ON(!(tmp & TRANS_DDI_FUNC_ENABLE));
+
 		if ((tmp & TRANS_DDI_MODE_SELECT_MASK) ==
 		    TRANS_DDI_MODE_SELECT_DP_MST)
 			mst_pipe_mask |= BIT(p);

Comments

On Fri, Nov 30, 2018 at 07:31:01AM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915/ddi: Check for unexpectedly disabled transcoders
> URL   : https://patchwork.freedesktop.org/series/53256/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_5224_full -> Patchwork_10959_full
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_10959_full absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_10959_full, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_10959_full:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@kms_draw_crc@draw-method-xrgb8888-pwrite-ytiled:
>     - shard-skl:          NOTRUN -> FAIL
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-wc:
>     - shard-kbl:          PASS -> FAIL

These are unrelated, the only effect of the change would be to emit a
warning, but that's not the case here.

> 
>   
> #### Warnings ####
> 
>   * igt@tools_test@tools_test:
>     - shard-snb:          PASS -> SKIP

The platform is unrelated to the change.

> 
>   
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_10959_full that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@drm_import_export@import-close-race-flink:
>     - shard-skl:          PASS -> TIMEOUT [fdo#108667]
> 
>   * igt@gem_ctx_isolation@vecs0-s3:
>     - shard-skl:          PASS -> INCOMPLETE [fdo#104108] / [fdo#107773]
> 
>   * igt@gem_exec_schedule@pi-ringfull-bsd:
>     - shard-skl:          NOTRUN -> FAIL [fdo#103158] +1
> 
>   * igt@gem_ppgtt@blt-vs-render-ctxn:
>     - shard-kbl:          PASS -> INCOMPLETE [fdo#103665] / [fdo#106023] / [fdo#106887]
> 
>   * igt@i915_hangman@hangcheck-unterminated:
>     - shard-apl:          PASS -> INCOMPLETE [fdo#103927]
> 
>   * igt@i915_suspend@fence-restore-tiled2untiled:
>     - shard-skl:          NOTRUN -> INCOMPLETE [fdo#104108] / [fdo#107773]
> 
>   * igt@kms_busy@extended-modeset-hang-newfb-render-a:
>     - {shard-iclb}:       PASS -> DMESG-WARN [fdo#107956]
> 
>   * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
>     - shard-skl:          NOTRUN -> DMESG-WARN [fdo#107956] +1
> 
>   * igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
>     - shard-glk:          PASS -> FAIL [fdo#108145]
> 
>   * igt@kms_chv_cursor_fail@pipe-a-128x128-bottom-edge:
>     - shard-skl:          NOTRUN -> FAIL [fdo#104671]
> 
>   * igt@kms_color@pipe-a-ctm-max:
>     - shard-apl:          PASS -> FAIL [fdo#108147]
> 
>   * igt@kms_cursor_crc@cursor-128x128-offscreen:
>     - shard-skl:          PASS -> FAIL [fdo#103232]
> 
>   * igt@kms_cursor_crc@cursor-128x128-suspend:
>     - shard-skl:          NOTRUN -> INCOMPLETE [fdo#104108]
> 
>   * igt@kms_cursor_crc@cursor-256x256-onscreen:
>     - shard-glk:          PASS -> FAIL [fdo#103232]
> 
>   * igt@kms_cursor_crc@cursor-256x85-offscreen:
>     - shard-skl:          NOTRUN -> FAIL [fdo#103232] +1
> 
>   * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
>     - shard-glk:          PASS -> FAIL [fdo#105363]
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu:
>     - shard-apl:          PASS -> FAIL [fdo#103167]
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
>     - shard-glk:          PASS -> FAIL [fdo#103167] +1
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
>     - {shard-iclb}:       PASS -> FAIL [fdo#103167] +3
> 
>   * igt@kms_frontbuffer_tracking@fbcpsr-tilingchange:
>     - shard-skl:          NOTRUN -> FAIL [fdo#105682] +2
> 
>   * igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt:
>     - shard-skl:          PASS -> INCOMPLETE [fdo#106978]
> 
>   * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt:
>     - shard-skl:          NOTRUN -> FAIL [fdo#103167] +2
> 
>   * igt@kms_plane@plane-position-covered-pipe-c-planes:
>     - shard-glk:          PASS -> FAIL [fdo#103166] +2
> 
>   * igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
>     - shard-skl:          NOTRUN -> FAIL [fdo#107815] / [fdo#108145] +1
> 
>   * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
>     - shard-skl:          NOTRUN -> FAIL [fdo#108145]
> 
>   * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
>     - shard-skl:          PASS -> FAIL [fdo#107815]
> 
>   * igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
>     - {shard-iclb}:       PASS -> FAIL [fdo#103166] +4
> 
>   * igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
>     - shard-apl:          PASS -> FAIL [fdo#103166]
> 
>   * igt@kms_rmfb@close-fd:
>     - {shard-iclb}:       PASS -> DMESG-WARN [fdo#107724] +1
> 
>   * igt@kms_rotation_crc@primary-rotation-180:
>     - shard-skl:          NOTRUN -> FAIL [fdo#103925] / [fdo#107815]
> 
>   * igt@kms_sysfs_edid_timing:
>     - shard-skl:          NOTRUN -> FAIL [fdo#100047]
> 
>   * igt@perf@polling:
>     - shard-hsw:          PASS -> FAIL [fdo#102252]
> 
>   * igt@pm_rpm@universal-planes:
>     - {shard-iclb}:       PASS -> DMESG-WARN [fdo#108654] / [fdo#108756]
> 
>   * {igt@runner@aborted}:
>     - {shard-iclb}:       NOTRUN -> FAIL [fdo#108756]
> 
>   
> #### Possible fixes ####
> 
>   * igt@kms_busy@extended-pageflip-hang-newfb-render-b:
>     - shard-glk:          DMESG-WARN [fdo#107956] -> PASS
> 
>   * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
>     - {shard-iclb}:       DMESG-WARN [fdo#107956] -> PASS
> 
>   * igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
>     - shard-glk:          FAIL [fdo#108145] -> PASS
> 
>   * igt@kms_cursor_crc@cursor-256x256-suspend:
>     - shard-skl:          INCOMPLETE [fdo#104108] -> PASS
> 
>   * igt@kms_cursor_crc@cursor-64x64-onscreen:
>     - shard-apl:          FAIL [fdo#103232] -> PASS +2
> 
>   * igt@kms_cursor_crc@cursor-size-change:
>     - shard-glk:          FAIL [fdo#103232] -> PASS +3
> 
>   * igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
>     - shard-glk:          FAIL [fdo#103060] -> PASS
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-cpu:
>     - shard-glk:          FAIL [fdo#103167] -> PASS +1
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
>     - {shard-iclb}:       FAIL [fdo#103167] -> PASS +1
> 
>   * igt@kms_plane@plane-position-covered-pipe-b-planes:
>     - shard-glk:          FAIL [fdo#103166] -> PASS
> 
>   * igt@kms_setmode@basic:
>     - shard-kbl:          FAIL [fdo#99912] -> PASS
> 
>   * igt@pm_rpm@modeset-non-lpsp-stress-no-wait:
>     - shard-skl:          INCOMPLETE [fdo#107807] -> SKIP
> 
>   * igt@pm_rpm@pm-tiling:
>     - shard-skl:          INCOMPLETE [fdo#107807] -> PASS
> 
>   * igt@pm_rpm@system-suspend-execbuf:
>     - shard-skl:          INCOMPLETE [fdo#104108] / [fdo#107807] -> PASS
> 
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
>   [fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
>   [fdo#102252]: https://bugs.freedesktop.org/show_bug.cgi?id=102252
>   [fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
>   [fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158
>   [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
>   [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
>   [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
>   [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
>   [fdo#103925]: https://bugs.freedesktop.org/show_bug.cgi?id=103925
>   [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
>   [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
>   [fdo#104671]: https://bugs.freedesktop.org/show_bug.cgi?id=104671
>   [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
>   [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
>   [fdo#106023]: https://bugs.freedesktop.org/show_bug.cgi?id=106023
>   [fdo#106887]: https://bugs.freedesktop.org/show_bug.cgi?id=106887
>   [fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
>   [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
>   [fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
>   [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
>   [fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
>   [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
>   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
>   [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
>   [fdo#108654]: https://bugs.freedesktop.org/show_bug.cgi?id=108654
>   [fdo#108667]: https://bugs.freedesktop.org/show_bug.cgi?id=108667
>   [fdo#108756]: https://bugs.freedesktop.org/show_bug.cgi?id=108756
>   [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
> 
> 
> Participating hosts (7 -> 7)
> ------------------------------
> 
>   No changes in participating hosts
> 
> 
> Build changes
> -------------
> 
>     * Linux: CI_DRM_5224 -> Patchwork_10959
> 
>   CI_DRM_5224: 67ee0d0da79f5b32636d496fd2127da1eecf6262 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_4736: 285ebfb3b7adc56586031afa5150c4e5ad40c229 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_10959: 21d18afdf5208f74d84deb414c00fcf80fc4edd1 @ git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10959/shards.html