[v2] EGL_EXT_image_dma_buf_import: add fbo option to yuv formats with alpha channel

Submitted by Lionel Landwerlin on Nov. 14, 2018, 11:10 a.m.

Details

Message ID 20181114111033.24576-1-lionel.g.landwerlin@intel.com
State New
Headers show
Series "EGL_EXT_image_dma_buf_import: add fbo option to yuv formats with alpha channel" ( rev: 1 ) in Piglit

Not browsing as part of any series.

Commit Message

Lionel Landwerlin Nov. 14, 2018, 11:10 a.m.
Depending on the platform you're running on, the test might fail with
the AYUV format. To make this reliable, force to render to fbo.

v2: request RGBA visual (Eric)

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
 tests/opengl.py                                  | 2 +-
 tests/spec/ext_image_dma_buf_import/sample_yuv.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/tests/opengl.py b/tests/opengl.py
index 8957de6e2..7c96e9412 100644
--- a/tests/opengl.py
+++ b/tests/opengl.py
@@ -3027,7 +3027,7 @@  with profile.test_list.group_manager(
       'ext_image_dma_buf_import-sample_yuv420', run_concurrent=False)
     g(['ext_image_dma_buf_import-sample_yuv', '-fmt=YV12'],
       'ext_image_dma_buf_import-sample_yvu420', run_concurrent=False)
-    g(['ext_image_dma_buf_import-sample_yuv', '-fmt=AYUV'],
+    g(['ext_image_dma_buf_import-sample_yuv', '-fmt=AYUV', '-fbo'],
       'ext_image_dma_buf_import-sample_ayuv', run_concurrent=False)
     g(['ext_image_dma_buf_import-transcode-nv12-as-r8-gr88'],
       'ext_image_dma_buf_import-transcode-nv12-as-r8-gr88',
diff --git a/tests/spec/ext_image_dma_buf_import/sample_yuv.c b/tests/spec/ext_image_dma_buf_import/sample_yuv.c
index 38c0ee697..ed9f87e0f 100644
--- a/tests/spec/ext_image_dma_buf_import/sample_yuv.c
+++ b/tests/spec/ext_image_dma_buf_import/sample_yuv.c
@@ -36,6 +36,7 @@ 
 PIGLIT_GL_TEST_CONFIG_BEGIN
 
 	config.supports_gl_es_version = 20;
+	config.window_visual = PIGLIT_GL_VISUAL_RGBA;
 
 PIGLIT_GL_TEST_CONFIG_END
 

Comments

Lionel Landwerlin <lionel.g.landwerlin@intel.com> writes:

> Depending on the platform you're running on, the test might fail with
> the AYUV format. To make this reliable, force to render to fbo.

It should be reliable with just the RGBA change.

Separately, I think you should be able to get the -fbo argument (and
thus fewer windows flickering during a test run) by just removing the
run_concurrent=False from the test setup.  That will improve the
performance of piglit runs while making these tests less special.
On 14/11/2018 17:12, Eric Anholt wrote:
> Lionel Landwerlin <lionel.g.landwerlin@intel.com> writes:
>
>> Depending on the platform you're running on, the test might fail with
>> the AYUV format. To make this reliable, force to render to fbo.
> It should be reliable with just the RGBA change.
>
> Separately, I think you should be able to get the -fbo argument (and
> thus fewer windows flickering during a test run) by just removing the
> run_concurrent=False from the test setup.  That will improve the
> performance of piglit runs while making these tests less special.

Indeed.

Dropping this patch in favor a new title.

Thanks!


-

Lionel