[v2] piglit/vbo: memory leak

Submitted by Sergii Romantsov on Oct. 24, 2018, 11:20 a.m.

Details

Message ID 1540380016-2540-1-git-send-email-sergii.romantsov@globallogic.com
State New
Headers show
Series "piglit/vbo: memory leak" ( rev: 2 ) in Piglit

Not browsing as part of any series.

Commit Message

Sergii Romantsov Oct. 24, 2018, 11:20 a.m.
Trivial fix of memory leaking for test 'initialized-vbo'.

v2: Rb added.

Fixes: 6a467e00cfae (security/initialized-vbo: test contents of uninitialized VBOs)
CC: Brian Paul <brianp@vmware.com>
Signed-off-by: Sergii Romantsov <sergii.romantsov@globallogic.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
---
 tests/security/initialized-vbo.c | 1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox

diff --git a/tests/security/initialized-vbo.c b/tests/security/initialized-vbo.c
index 20c8155..16656bc 100644
--- a/tests/security/initialized-vbo.c
+++ b/tests/security/initialized-vbo.c
@@ -70,6 +70,7 @@  piglit_display(void)
 
 	glDeleteBuffers(1, &buf);
 
+	free(tmp);
 	return pass ? PIGLIT_PASS : PIGLIT_WARN;
 }
 

Comments

On 10/24/2018 05:20 AM, Sergii Romantsov wrote:
> Trivial fix of memory leaking for test 'initialized-vbo'.

> 

> v2: Rb added.

> 

> Fixes: 6a467e00cfae (security/initialized-vbo: test contents of uninitialized VBOs)

> CC: Brian Paul <brianp@vmware.com>

> Signed-off-by: Sergii Romantsov <sergii.romantsov@globallogic.com>

> Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>

> ---

>   tests/security/initialized-vbo.c | 1 +

>   1 file changed, 1 insertion(+)

> 

> diff --git a/tests/security/initialized-vbo.c b/tests/security/initialized-vbo.c

> index 20c8155..16656bc 100644

> --- a/tests/security/initialized-vbo.c

> +++ b/tests/security/initialized-vbo.c

> @@ -70,6 +70,7 @@ piglit_display(void)

>   

>   	glDeleteBuffers(1, &buf);

>   

> +	free(tmp);

>   	return pass ? PIGLIT_PASS : PIGLIT_WARN;

>   }

>   

> 



Reviewed-by: Brian Paul <brianp@vmware.com>


Need me to push this for you?
Thanks.
Yes, please, push.


On Wed, Oct 24, 2018 at 5:26 PM Brian Paul <brianp@vmware.com> wrote:

> On 10/24/2018 05:20 AM, Sergii Romantsov wrote:
> > Trivial fix of memory leaking for test 'initialized-vbo'.
> >
> > v2: Rb added.
> >
> > Fixes: 6a467e00cfae (security/initialized-vbo: test contents of
> uninitialized VBOs)
> > CC: Brian Paul <brianp@vmware.com>
> > Signed-off-by: Sergii Romantsov <sergii.romantsov@globallogic.com>
> > Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
> > ---
> >   tests/security/initialized-vbo.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/security/initialized-vbo.c
> b/tests/security/initialized-vbo.c
> > index 20c8155..16656bc 100644
> > --- a/tests/security/initialized-vbo.c
> > +++ b/tests/security/initialized-vbo.c
> > @@ -70,6 +70,7 @@ piglit_display(void)
> >
> >       glDeleteBuffers(1, &buf);
> >
> > +     free(tmp);
> >       return pass ? PIGLIT_PASS : PIGLIT_WARN;
> >   }
> >
> >
>
>
> Reviewed-by: Brian Paul <brianp@vmware.com>
>
> Need me to push this for you?
>