radv: reduce max{Uniform, Storage}BufferRange values

Submitted by Samuel Pitoiset on Oct. 9, 2018, 1:39 p.m.

Details

Message ID 20181009133950.25502-1-samuel.pitoiset@gmail.com
State New
Headers show
Series "radv: reduce max{Uniform, Storage}BufferRange values" ( rev: 1 ) in Mesa

Not browsing as part of any series.

Commit Message

Samuel Pitoiset Oct. 9, 2018, 1:39 p.m.
2^32-1 is too high.

This fixes the following crucible tests:
stress.limits.buffer-update.range.uniform
stress.limits.buffer-update.range.storage

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
---
 src/amd/vulkan/radv_device.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 429d47325a3..18a373bdcbf 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -887,8 +887,8 @@  void radv_GetPhysicalDeviceProperties(
 		.maxImageDimensionCube                    = (1 << 14),
 		.maxImageArrayLayers                      = (1 << 11),
 		.maxTexelBufferElements                   = 128 * 1024 * 1024,
-		.maxUniformBufferRange                    = UINT32_MAX,
-		.maxStorageBufferRange                    = UINT32_MAX,
+		.maxUniformBufferRange                    = (1ul << 31),
+		.maxStorageBufferRange                    = (1ul << 31),
 		.maxPushConstantsSize                     = MAX_PUSH_CONSTANTS_SIZE,
 		.maxMemoryAllocationCount                 = UINT32_MAX,
 		.maxSamplerAllocationCount                = 64 * 1024,

Comments

On Tue, Oct 9, 2018 at 3:40 PM Samuel Pitoiset
<samuel.pitoiset@gmail.com> wrote:
>
> 2^32-1 is too high.
>
> This fixes the following crucible tests:
> stress.limits.buffer-update.range.uniform
> stress.limits.buffer-update.range.storage

This is just an allocation test, it passes for me on Vega so make this
GPU specific? Also even on Polaris, I could allocate 0xffa00000 bytes.
Furthermore we need to update maxMemoryAllocationSize and calculations
for the maximum descriptor set sizes.

> Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
> ---
>  src/amd/vulkan/radv_device.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> index 429d47325a3..18a373bdcbf 100644
> --- a/src/amd/vulkan/radv_device.c
> +++ b/src/amd/vulkan/radv_device.c
> @@ -887,8 +887,8 @@ void radv_GetPhysicalDeviceProperties(
>                 .maxImageDimensionCube                    = (1 << 14),
>                 .maxImageArrayLayers                      = (1 << 11),
>                 .maxTexelBufferElements                   = 128 * 1024 * 1024,
> -               .maxUniformBufferRange                    = UINT32_MAX,
> -               .maxStorageBufferRange                    = UINT32_MAX,
> +               .maxUniformBufferRange                    = (1ul << 31),
> +               .maxStorageBufferRange                    = (1ul << 31),
>                 .maxPushConstantsSize                     = MAX_PUSH_CONSTANTS_SIZE,
>                 .maxMemoryAllocationCount                 = UINT32_MAX,
>                 .maxSamplerAllocationCount                = 64 * 1024,
> --
> 2.19.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev