[v2] protocol: warn clients about some wl_output properties

Submitted by Simon Ser on Oct. 5, 2018, 6:09 p.m.

Details

Message ID fdBsqErTgZYTqbDHMJ8NWkcOpDuuc64yvnFEap4f--oF5Udgt9FzaI42AeKHFkkoLEiNYfDehDZ9jfL_VMmA1fbOdt63-4N5_UZ8RTcXrVU=@emersion.fr
State New
Series "protocol: warn clients about some wl_output properties"
Headers show

Commit Message

Simon Ser Oct. 5, 2018, 6:09 p.m.
All wl_output properties don't always make sense for all
compositors.

Some compositors might not implement a "global compositor space",
(e.g. 3D compositors) in which case properties like x and y don't
make sense.

Some compositors might expose virtual outputs, in which case modes,
make and model are not relevant.

In a lot of these situations, information from xdg_output is better
suited.

Signed-off-by: Simon Ser <contact@emersion.fr>
---

Changes from v1 to v2: added a note about presentation-time

 protocol/wayland.xml | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/protocol/wayland.xml b/protocol/wayland.xml
index 141038b..fd657ae 100644
--- a/protocol/wayland.xml
+++ b/protocol/wayland.xml
@@ -2402,6 +2402,13 @@ 
 
 	The physical size can be set to zero if it doesn't make sense for this
 	output (e.g. for projectors or virtual outputs).
+
+	Note: wl_output only advertises partial information about the output
+	position and identification. Some compositors, for instance those not
+	implementing a desktop-style output layout or those exposing virtual
+	outputs, might fake this information. Instead of using x and y, clients
+	should use xdg_output.logical_position. Instead of using make and model,
+	clients should use xdg_output.name and xdg_output.description.
       </description>
       <arg name="x" type="int"
 	   summary="x position within the global compositor space"/>
@@ -2446,7 +2453,16 @@ 
 	the output device. This is not necessarily the same as
 	the output size in the global compositor space. For instance,
 	the output may be scaled, as described in wl_output.scale,
-	or transformed, as described in wl_output.transform.
+	or transformed, as described in wl_output.transform. Clients
+	willing to retrieve the output size in the global compositor
+	space should use xdg_output.logical_size instead.
+
+	Clients should not use the refresh rate to schedule frames. Instead,
+	they should use the presentation-time protocol.
+
+	Note: this information is not always meaningful for all outputs. Some
+	compositors, such as those exposing virtual outputs, might fake the
+	refresh rate or the size.
       </description>
       <arg name="flags" type="uint" enum="mode" summary="bitfield of mode flags"/>
       <arg name="width" type="int" summary="width of the mode in hardware units"/>