[Spice-devel,01/12] Revert "miniport: halve QXL_IO_UPDATE_IRQ calls"

Submitted by Alon Levy on April 30, 2014, 2:40 p.m.

Details

Message ID 1398868836-15212-2-git-send-email-alevy@redhat.com
State New
Headers show

Not browsing as part of any series.

Commit Message

Alon Levy April 30, 2014, 2:40 p.m.
From: Yonit Halperin <yhalperi@redhat.com>

This reverts commit 49feefa95d3595f04355c4aed53ec5bf26551046.
The patch causes the display to get stuck. Till we understand exactly
why, I'm reverting it.
---
 xddm/miniport/qxl.c | 1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox

diff --git a/xddm/miniport/qxl.c b/xddm/miniport/qxl.c
index ce37f07..f5d6b48 100644
--- a/xddm/miniport/qxl.c
+++ b/xddm/miniport/qxl.c
@@ -1321,6 +1321,7 @@  BOOLEAN Interrupt(PVOID dev_extension)
         return FALSE;
     }
     dev_ext->ram_header->int_mask = 0;
+    VideoPortWritePortUchar((PUCHAR)dev_ext->io_base + QXL_IO_UPDATE_IRQ, 0);
 
     if (!VideoPortQueueDpc(dev_extension, InterruptCallback, NULL)) {
         VideoPortLogError(dev_extension, NULL, E_UNEXPECTED, QXLERR_INT_DELIVERY);

Comments

ack,

should the bug state be changed back to ASSIGNED?

----- Original Message -----
> From: Yonit Halperin <yhalperi@redhat.com>
> 
> This reverts commit 49feefa95d3595f04355c4aed53ec5bf26551046.
> The patch causes the display to get stuck. Till we understand exactly
> why, I'm reverting it.
> ---
>  xddm/miniport/qxl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/xddm/miniport/qxl.c b/xddm/miniport/qxl.c
> index ce37f07..f5d6b48 100644
> --- a/xddm/miniport/qxl.c
> +++ b/xddm/miniport/qxl.c
> @@ -1321,6 +1321,7 @@ BOOLEAN Interrupt(PVOID dev_extension)
>          return FALSE;
>      }
>      dev_ext->ram_header->int_mask = 0;
> +    VideoPortWritePortUchar((PUCHAR)dev_ext->io_base + QXL_IO_UPDATE_IRQ,
> 0);
>  
>      if (!VideoPortQueueDpc(dev_extension, InterruptCallback, NULL)) {
>          VideoPortLogError(dev_extension, NULL, E_UNEXPECTED,
>          QXLERR_INT_DELIVERY);
> --
> 1.9.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>
On 04/30/2014 07:28 PM, Marc-André Lureau wrote:
> ack,
> 
> should the bug state be changed back to ASSIGNED?

I did that.

> 
> ----- Original Message -----
>> From: Yonit Halperin <yhalperi@redhat.com>
>>
>> This reverts commit 49feefa95d3595f04355c4aed53ec5bf26551046.
>> The patch causes the display to get stuck. Till we understand exactly
>> why, I'm reverting it.
>> ---
>>  xddm/miniport/qxl.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/xddm/miniport/qxl.c b/xddm/miniport/qxl.c
>> index ce37f07..f5d6b48 100644
>> --- a/xddm/miniport/qxl.c
>> +++ b/xddm/miniport/qxl.c
>> @@ -1321,6 +1321,7 @@ BOOLEAN Interrupt(PVOID dev_extension)
>>          return FALSE;
>>      }
>>      dev_ext->ram_header->int_mask = 0;
>> +    VideoPortWritePortUchar((PUCHAR)dev_ext->io_base + QXL_IO_UPDATE_IRQ,
>> 0);
>>  
>>      if (!VideoPortQueueDpc(dev_extension, InterruptCallback, NULL)) {
>>          VideoPortLogError(dev_extension, NULL, E_UNEXPECTED,
>>          QXLERR_INT_DELIVERY);
>> --
>> 1.9.0
>>
>> _______________________________________________
>> Spice-devel mailing list
>> Spice-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>>