gles-3.0: test for vertex attribute aliasing

Submitted by Tapani Pälli on Sept. 25, 2018, 6:13 a.m.

Details

Message ID 20180925061321.16247-1-tapani.palli@intel.com
State New
Headers show
Series "gles-3.0: test for vertex attribute aliasing" ( rev: 1 ) in Piglit

Not browsing as part of any series.

Commit Message

Tapani Pälli Sept. 25, 2018, 6:13 a.m.
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106833
---
 tests/opengl.py                          |  1 +
 tests/spec/gles-3.0/CMakeLists.gles3.txt |  1 +
 tests/spec/gles-3.0/attribute-aliasing.c | 91 ++++++++++++++++++++++++
 3 files changed, 93 insertions(+)
 create mode 100644 tests/spec/gles-3.0/attribute-aliasing.c

Patch hide | download patch | download mbox

diff --git a/tests/opengl.py b/tests/opengl.py
index c599eb180..e1a5ef823 100644
--- a/tests/opengl.py
+++ b/tests/opengl.py
@@ -4637,6 +4637,7 @@  with profile.test_list.group_manager(
     g(['texture-immutable-levels_gles3'], 'texture-immutable-levels')
     g(['gles-3.0-drawarrays-vertexid'], 'gl_VertexID used with glDrawArrays')
     g(['gles-3.0-transform-feedback-uniform-buffer-object'])
+    g(['gles-3.0-attribute-aliasing'], 'vertex attribute aliasing')
 
     for test_mode in ['teximage', 'texsubimage']:
         g(['ext_texture_array-compressed_gles3', test_mode, '-fbo'],
diff --git a/tests/spec/gles-3.0/CMakeLists.gles3.txt b/tests/spec/gles-3.0/CMakeLists.gles3.txt
index acaf64574..9f7ffe8ce 100644
--- a/tests/spec/gles-3.0/CMakeLists.gles3.txt
+++ b/tests/spec/gles-3.0/CMakeLists.gles3.txt
@@ -8,5 +8,6 @@  piglit_add_executable(oes_compressed_etc2_texture-miptree_gles3 oes_compressed_e
 piglit_add_executable(texture-immutable-levels_gles3 texture-immutable-levels.c)
 piglit_add_executable(read_depth_gles3 read-depth.c)
 piglit_add_executable(gles-3.0-transform-feedback-uniform-buffer-object transform-feedback-uniform-buffer-object.c)
+piglit_add_executable(gles-3.0-attribute-aliasing attribute-aliasing.c)
 
 # vim: ft=cmake:
diff --git a/tests/spec/gles-3.0/attribute-aliasing.c b/tests/spec/gles-3.0/attribute-aliasing.c
new file mode 100644
index 000000000..9a87dbf92
--- /dev/null
+++ b/tests/spec/gles-3.0/attribute-aliasing.c
@@ -0,0 +1,91 @@ 
+/*
+ * Copyright © 2018 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/**
+ * @file
+ * Test that vertex attribute aliasing is disallowed.
+ *
+ * From OpenGL ES 3.0.5 spec "2.12.5 Vertex Attributes":
+ *
+ *    "Binding more than one attribute name to the same location is referred
+ *     to as aliasing, and is not permitted in OpenGL ES Shading Language 3.00
+ *     vertex shaders. LinkProgram will fail when this condition exists."
+ */
+
+#include "piglit-util-gl.h"
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+	config.supports_gl_es_version = 30;
+PIGLIT_GL_TEST_CONFIG_END
+
+static const char vs_source[] =
+	"#version 300 es\n"
+	"in highp float a;\n"
+	"in highp float b;\n"
+	"void main()\n"
+	"{\n"
+	"	gl_Position = vec4(0.0);\n"
+	"}\n";
+
+static const char fs_source[] =
+	"#version 300 es\n"
+	"out highp vec4 color;\n"
+	"void main()\n"
+	"{\n"
+	"	color = vec4(0.0);\n"
+	"}\n";
+
+enum piglit_result
+piglit_display(void)
+{
+	return PIGLIT_FAIL;
+}
+
+void
+piglit_init(int argc, char **argv)
+{
+	GLuint vs, fs, prog;
+
+	prog = glCreateProgram();
+
+	/* Bind 2 attributes to the same location. */
+	glBindAttribLocation(prog, 0, "a");
+	glBindAttribLocation(prog, 0, "b");
+
+	vs = piglit_compile_shader_text(GL_VERTEX_SHADER, vs_source);
+	fs = piglit_compile_shader_text(GL_FRAGMENT_SHADER, fs_source);
+
+	glAttachShader(prog, vs);
+	glAttachShader(prog, fs);
+
+	glLinkProgram(prog);
+
+	if (piglit_link_check_status_quiet(prog))
+		piglit_report_result(PIGLIT_FAIL);
+
+	glDeleteShader(vs);
+	glDeleteShader(fs);
+	glDeleteProgram(prog);
+
+	piglit_report_result(PIGLIT_PASS);
+}

Comments

I realized this test deserves a bit more spec reference, will add 
following locally.

OpenGL ES SL 3/3.10/3.20 spec:

"The existence of aliasing is determined by declarations present after 
preprocessing."

So .. it does not matter if those inputs are actually used, it is still 
considered aliasing.


On 9/25/18 9:13 AM, Tapani Pälli wrote:
> Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106833
> ---
>   tests/opengl.py                          |  1 +
>   tests/spec/gles-3.0/CMakeLists.gles3.txt |  1 +
>   tests/spec/gles-3.0/attribute-aliasing.c | 91 ++++++++++++++++++++++++
>   3 files changed, 93 insertions(+)
>   create mode 100644 tests/spec/gles-3.0/attribute-aliasing.c
> 
> diff --git a/tests/opengl.py b/tests/opengl.py
> index c599eb180..e1a5ef823 100644
> --- a/tests/opengl.py
> +++ b/tests/opengl.py
> @@ -4637,6 +4637,7 @@ with profile.test_list.group_manager(
>       g(['texture-immutable-levels_gles3'], 'texture-immutable-levels')
>       g(['gles-3.0-drawarrays-vertexid'], 'gl_VertexID used with glDrawArrays')
>       g(['gles-3.0-transform-feedback-uniform-buffer-object'])
> +    g(['gles-3.0-attribute-aliasing'], 'vertex attribute aliasing')
>   
>       for test_mode in ['teximage', 'texsubimage']:
>           g(['ext_texture_array-compressed_gles3', test_mode, '-fbo'],
> diff --git a/tests/spec/gles-3.0/CMakeLists.gles3.txt b/tests/spec/gles-3.0/CMakeLists.gles3.txt
> index acaf64574..9f7ffe8ce 100644
> --- a/tests/spec/gles-3.0/CMakeLists.gles3.txt
> +++ b/tests/spec/gles-3.0/CMakeLists.gles3.txt
> @@ -8,5 +8,6 @@ piglit_add_executable(oes_compressed_etc2_texture-miptree_gles3 oes_compressed_e
>   piglit_add_executable(texture-immutable-levels_gles3 texture-immutable-levels.c)
>   piglit_add_executable(read_depth_gles3 read-depth.c)
>   piglit_add_executable(gles-3.0-transform-feedback-uniform-buffer-object transform-feedback-uniform-buffer-object.c)
> +piglit_add_executable(gles-3.0-attribute-aliasing attribute-aliasing.c)
>   
>   # vim: ft=cmake:
> diff --git a/tests/spec/gles-3.0/attribute-aliasing.c b/tests/spec/gles-3.0/attribute-aliasing.c
> new file mode 100644
> index 000000000..9a87dbf92
> --- /dev/null
> +++ b/tests/spec/gles-3.0/attribute-aliasing.c
> @@ -0,0 +1,91 @@
> +/*
> + * Copyright © 2018 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + */
> +
> +/**
> + * @file
> + * Test that vertex attribute aliasing is disallowed.
> + *
> + * From OpenGL ES 3.0.5 spec "2.12.5 Vertex Attributes":
> + *
> + *    "Binding more than one attribute name to the same location is referred
> + *     to as aliasing, and is not permitted in OpenGL ES Shading Language 3.00
> + *     vertex shaders. LinkProgram will fail when this condition exists."
> + */
> +
> +#include "piglit-util-gl.h"
> +
> +PIGLIT_GL_TEST_CONFIG_BEGIN
> +	config.supports_gl_es_version = 30;
> +PIGLIT_GL_TEST_CONFIG_END
> +
> +static const char vs_source[] =
> +	"#version 300 es\n"
> +	"in highp float a;\n"
> +	"in highp float b;\n"
> +	"void main()\n"
> +	"{\n"
> +	"	gl_Position = vec4(0.0);\n"
> +	"}\n";
> +
> +static const char fs_source[] =
> +	"#version 300 es\n"
> +	"out highp vec4 color;\n"
> +	"void main()\n"
> +	"{\n"
> +	"	color = vec4(0.0);\n"
> +	"}\n";
> +
> +enum piglit_result
> +piglit_display(void)
> +{
> +	return PIGLIT_FAIL;
> +}
> +
> +void
> +piglit_init(int argc, char **argv)
> +{
> +	GLuint vs, fs, prog;
> +
> +	prog = glCreateProgram();
> +
> +	/* Bind 2 attributes to the same location. */
> +	glBindAttribLocation(prog, 0, "a");
> +	glBindAttribLocation(prog, 0, "b");
> +
> +	vs = piglit_compile_shader_text(GL_VERTEX_SHADER, vs_source);
> +	fs = piglit_compile_shader_text(GL_FRAGMENT_SHADER, fs_source);
> +
> +	glAttachShader(prog, vs);
> +	glAttachShader(prog, fs);
> +
> +	glLinkProgram(prog);
> +
> +	if (piglit_link_check_status_quiet(prog))
> +		piglit_report_result(PIGLIT_FAIL);
> +
> +	glDeleteShader(vs);
> +	glDeleteShader(fs);
> +	glDeleteProgram(prog);
> +
> +	piglit_report_result(PIGLIT_PASS);
> +}
>