staging/vboxvideo: Replace ttm_bo_unref with ttm_bo_put

Submitted by Thomas Zimmermann on Sept. 10, 2018, 9:36 a.m.

Details

Message ID 20180910093644.17558-1-tzimmermann@suse.de
State New
Headers show
Series "staging/vboxvideo: Replace ttm_bo_unref with ttm_bo_put" ( rev: 2 ) in DRI devel

Not browsing as part of any series.

Commit Message

Thomas Zimmermann Sept. 10, 2018, 9:36 a.m.
The function ttm_bo_put releases a reference to a TTM buffer object. The
function's name is more aligned to the Linux kernel convention of naming
ref-counting function _get and _put.

A call to ttm_bo_unref takes the address of the TTM BO object's pointer and
clears the pointer's value to NULL. This is not necessary in most cases and
sometimes even worked around by the calling code. A call to ttm_bo_put only
releases the reference without clearing the pointer.

The current behaviour of cleaning the pointer is kept in the calling code,
but should be removed if not required in a later patch.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/staging/vboxvideo/vbox_main.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/staging/vboxvideo/vbox_main.c b/drivers/staging/vboxvideo/vbox_main.c
index 429f6a453619..b6cff31903b3 100644
--- a/drivers/staging/vboxvideo/vbox_main.c
+++ b/drivers/staging/vboxvideo/vbox_main.c
@@ -490,9 +490,8 @@  static void vbox_bo_unref(struct vbox_bo **bo)
 		return;
 
 	tbo = &((*bo)->bo);
-	ttm_bo_unref(&tbo);
-	if (!tbo)
-		*bo = NULL;
+	ttm_bo_put(tbo);
+	*bo = NULL;
 }
 
 void vbox_gem_free_object(struct drm_gem_object *obj)