[1/5] drm: fix syncobj null_fence_enable_signaling

Submitted by Zhou, David(ChunMing) on Aug. 30, 2018, 6:48 a.m.

Details

Message ID 20180830064831.5868-1-david1.zhou@amd.com
State New
Headers show
Series "Series without cover letter" ( rev: 1 ) in AMD X.Org drivers

Not browsing as part of any series.

Commit Message

Zhou, David(ChunMing) Aug. 30, 2018, 6:48 a.m.
That is certainly totally nonsense. dma_fence_enable_sw_signaling()
is the function who is calling this callback.

Signed-off-by: Chunming Zhou <david1.zhou@amd.com>
Cc: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Christian König <christian.koenig@amd.com>
Acked-by: Daniel Vetter <daniel@ffwll.ch>
---
 drivers/gpu/drm/drm_syncobj.c | 1 -
 1 file changed, 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
index 3a8837c49639..d17ed75ac7e2 100644
--- a/drivers/gpu/drm/drm_syncobj.c
+++ b/drivers/gpu/drm/drm_syncobj.c
@@ -184,7 +184,6 @@  static const char *drm_syncobj_null_fence_get_name(struct dma_fence *fence)
 
 static bool drm_syncobj_null_fence_enable_signaling(struct dma_fence *fence)
 {
-    dma_fence_enable_sw_signaling(fence);
     return !dma_fence_is_signaled(fence);
 }
 

Comments

Am 30.08.2018 um 08:48 schrieb Chunming Zhou:
> That is certainly totally nonsense. dma_fence_enable_sw_signaling()
> is the function who is calling this callback.
>
> Signed-off-by: Chunming Zhou <david1.zhou@amd.com>
> Cc: Jason Ekstrand <jason@jlekstrand.net>
> Reviewed-by: Christian König <christian.koenig@amd.com>
> Acked-by: Daniel Vetter <daniel@ffwll.ch>

If there are no objections I'm going to push patches #1-#4 to drm-misc-next.

Independent of the timeline sync object work they look like nice 
cleanups to me.

Regards,
Christian.

> ---
>   drivers/gpu/drm/drm_syncobj.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> index 3a8837c49639..d17ed75ac7e2 100644
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -184,7 +184,6 @@ static const char *drm_syncobj_null_fence_get_name(struct dma_fence *fence)
>   
>   static bool drm_syncobj_null_fence_enable_signaling(struct dma_fence *fence)
>   {
> -    dma_fence_enable_sw_signaling(fence);
>       return !dma_fence_is_signaled(fence);
>   }
>