[spice-gtk,2/2] flatpak: Move to 3.26 runtime version

Submitted by Victor Toso on Aug. 6, 2018, 11:15 a.m.

Details

Message ID 20180806111538.32284-2-victortoso@redhat.com
State New
Headers show
Series "Series without cover letter" ( rev: 1 ) in Spice

Not browsing as part of any series.

Commit Message

Victor Toso Aug. 6, 2018, 11:15 a.m.
From: Victor Toso <me@victortoso.com>

As we have OPUS in 3.26, which means audio playback.
This patch also changes the git url to gitlab.

Signed-off-by: Victor Toso <victortoso@redhat.com>
---
 data/org.spicespace.spicy.json | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Patch hide | download patch | download mbox

diff --git a/data/org.spicespace.spicy.json b/data/org.spicespace.spicy.json
index 064b9a6..7243508 100644
--- a/data/org.spicespace.spicy.json
+++ b/data/org.spicespace.spicy.json
@@ -1,7 +1,7 @@ 
 {
     "app-id": "org.spicespace.spicy",
     "runtime": "org.gnome.Platform",
-    "runtime-version": "3.24",
+    "runtime-version": "3.26",
     "sdk": "org.gnome.Sdk",
     "command": "spicy",
     "tags": ["devel", "development", "nightly"],
@@ -46,7 +46,7 @@ 
             "sources": [
                 {
                     "type": "git",
-                    "url": "git://anongit.freedesktop.org/spice/spice-protocol"
+                    "url": "https://gitlab.freedesktop.org/spice/spice-protocol.git"
                 }
             ]
         },
@@ -63,7 +63,7 @@ 
             "sources": [
                 {
                     "type": "git",
-                    "url": "git://anongit.freedesktop.org/spice/spice-gtk"
+                    "url": "https://gitlab.freedesktop.org/spice/spice-gtk.git"
                 }
             ]
         }

Comments

> 
> From: Victor Toso <me@victortoso.com>
> 
> As we have OPUS in 3.26, which means audio playback.

I don't know why it does not sound that great, maybe my English.

> This patch also changes the git url to gitlab.
> 

Can you split? Not hard with git-gui or similar tool

> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
>  data/org.spicespace.spicy.json | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/data/org.spicespace.spicy.json b/data/org.spicespace.spicy.json
> index 064b9a6..7243508 100644
> --- a/data/org.spicespace.spicy.json
> +++ b/data/org.spicespace.spicy.json
> @@ -1,7 +1,7 @@
>  {
>      "app-id": "org.spicespace.spicy",
>      "runtime": "org.gnome.Platform",
> -    "runtime-version": "3.24",
> +    "runtime-version": "3.26",
>      "sdk": "org.gnome.Sdk",
>      "command": "spicy",
>      "tags": ["devel", "development", "nightly"],
> @@ -46,7 +46,7 @@
>              "sources": [
>                  {
>                      "type": "git",
> -                    "url":
> "git://anongit.freedesktop.org/spice/spice-protocol"
> +                    "url":
> "https://gitlab.freedesktop.org/spice/spice-protocol.git"
>                  }
>              ]
>          },
> @@ -63,7 +63,7 @@
>              "sources": [
>                  {
>                      "type": "git",
> -                    "url": "git://anongit.freedesktop.org/spice/spice-gtk"
> +                    "url":
> "https://gitlab.freedesktop.org/spice/spice-gtk.git"
>                  }
>              ]
>          }

Frediano
Hi,

On Mon, Aug 06, 2018 at 09:47:51AM -0400, Frediano Ziglio wrote:
> > 
> > From: Victor Toso <me@victortoso.com>
> > 
> > As we have OPUS in 3.26, which means audio playback.
> 
> I don't know why it does not sound that great, maybe my English.

I'll put it as "3.26 runtime was release $date and includes Opus
which enables playback audio in flatpack"

> 
> > This patch also changes the git url to gitlab.
> > 
> 
> Can you split? Not hard with git-gui or similar tool

I can't see a strong reason to split it but I don't really mind.
I'll send it later today.

Thanks for review,


> 
> > Signed-off-by: Victor Toso <victortoso@redhat.com>
> > ---
> >  data/org.spicespace.spicy.json | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/data/org.spicespace.spicy.json b/data/org.spicespace.spicy.json
> > index 064b9a6..7243508 100644
> > --- a/data/org.spicespace.spicy.json
> > +++ b/data/org.spicespace.spicy.json
> > @@ -1,7 +1,7 @@
> >  {
> >      "app-id": "org.spicespace.spicy",
> >      "runtime": "org.gnome.Platform",
> > -    "runtime-version": "3.24",
> > +    "runtime-version": "3.26",
> >      "sdk": "org.gnome.Sdk",
> >      "command": "spicy",
> >      "tags": ["devel", "development", "nightly"],
> > @@ -46,7 +46,7 @@
> >              "sources": [
> >                  {
> >                      "type": "git",
> > -                    "url":
> > "git://anongit.freedesktop.org/spice/spice-protocol"
> > +                    "url":
> > "https://gitlab.freedesktop.org/spice/spice-protocol.git"
> >                  }
> >              ]
> >          },
> > @@ -63,7 +63,7 @@
> >              "sources": [
> >                  {
> >                      "type": "git",
> > -                    "url": "git://anongit.freedesktop.org/spice/spice-gtk"
> > +                    "url":
> > "https://gitlab.freedesktop.org/spice/spice-gtk.git"
> >                  }
> >              ]
> >          }
> 
> Frediano
Hi,

On Mon, Aug 06, 2018 at 09:47:51AM -0400, Frediano Ziglio wrote:
> > 
> > From: Victor Toso <me@victortoso.com>
> > 
> > As we have OPUS in 3.26, which means audio playback.
> 
> I don't know why it does not sound that great, maybe my English.

I started to play around with this so I might add some changes to
it, I'll follow up with a patch later.

> > This patch also changes the git url to gitlab.

Sending only this one for now.

Cheers,

> 
> Can you split? Not hard with git-gui or similar tool
> 
> > Signed-off-by: Victor Toso <victortoso@redhat.com>
> > ---
> >  data/org.spicespace.spicy.json | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/data/org.spicespace.spicy.json b/data/org.spicespace.spicy.json
> > index 064b9a6..7243508 100644
> > --- a/data/org.spicespace.spicy.json
> > +++ b/data/org.spicespace.spicy.json
> > @@ -1,7 +1,7 @@
> >  {
> >      "app-id": "org.spicespace.spicy",
> >      "runtime": "org.gnome.Platform",
> > -    "runtime-version": "3.24",
> > +    "runtime-version": "3.26",
> >      "sdk": "org.gnome.Sdk",
> >      "command": "spicy",
> >      "tags": ["devel", "development", "nightly"],
> > @@ -46,7 +46,7 @@
> >              "sources": [
> >                  {
> >                      "type": "git",
> > -                    "url":
> > "git://anongit.freedesktop.org/spice/spice-protocol"
> > +                    "url":
> > "https://gitlab.freedesktop.org/spice/spice-protocol.git"
> >                  }
> >              ]
> >          },
> > @@ -63,7 +63,7 @@
> >              "sources": [
> >                  {
> >                      "type": "git",
> > -                    "url": "git://anongit.freedesktop.org/spice/spice-gtk"
> > +                    "url":
> > "https://gitlab.freedesktop.org/spice/spice-gtk.git"
> >                  }
> >              ]
> >          }
> 
> Frediano