[5/5] contributing: Weston now uses GitLab MRs

Submitted by Daniel Stone on Aug. 6, 2018, 11:09 a.m.

Details

Message ID 20180806110924.13152-6-daniels@collabora.com
State Accepted
Commit 1e4af929d2be8e1fd277100558a0ecc44e3fe6ed
Headers show
Series "Weston contributing doc, GitLab MRs" ( rev: 1 ) in Wayland (DEPRECATED)

Not browsing as part of any series.

Commit Message

Daniel Stone Aug. 6, 2018, 11:09 a.m.
Note that Weston uses GitLab MRs for review, not mail.

Signed-off-by: Daniel Stone <daniels@collabora.com>
---
 CONTRIBUTING.md | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

Patch hide | download patch | download mbox

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 4273d99d..686ed63f 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -55,12 +55,16 @@  Tracking patches and following up
 ---------------------------------
 
 [Wayland Patchwork](http://patchwork.freedesktop.org/project/wayland/list/) is
-used for tracking patches to Wayland and Weston. Xwayland patches are tracked
-with the [Xorg project](https://patchwork.freedesktop.org/project/Xorg/list/)
-instead. Libinput patches, even though they use the same mailing list as
+used for tracking patches to Wayland. Xwayland patches are tracked with the
+[Xorg project](https://patchwork.freedesktop.org/project/Xorg/list/)
+instead. Weston uses
+[GitLab merge requests](https://gitlab.freedesktop.org/wayland/weston/merge_requests)
+for code review, and does not use mailing list review at all.
+
+Libinput patches, even though they use the same mailing list as
 Wayland, are not tracked in the Wayland Patchwork.
 
-The following applies only to Wayland and Weston.
+The following applies only to Wayland.
 
 If a patch is not found in Patchwork, there is a high possibility for it to be
 forgotten. Patches attached to bug reports or not arriving to the mailing list
@@ -93,8 +97,8 @@  The following patch states are found in Patchwork:
     Request for comments, not meant to be merged as is.
 
 - **Not applicable**:
-    The email was not actually a patch, or the patch is not for Wayland or
-    Weston. Libinput patches are usually automatically ignored by Wayland
+    The email was not actually a patch, or the patch is not for Wayland.
+    Libinput patches are usually automatically ignored by Wayland
     Patchwork, but if they get through, they will be marked as Not
     applicable.
 
@@ -121,7 +125,7 @@  shown.
 
 There is also a command line interface to Patchwork called `pwclient`, see
 http://patchwork.freedesktop.org/project/wayland/
-for links where to get it and the sample `.pwclientrc` for Wayland/Weston.
+for links where to get it and the sample `.pwclientrc` for Wayland.
 
 
 Coding style

Comments

On Mon,  6 Aug 2018 12:09:24 +0100
Daniel Stone <daniels@collabora.com> wrote:

> Note that Weston uses GitLab MRs for review, not mail.
> 
> Signed-off-by: Daniel Stone <daniels@collabora.com>
> ---
>  CONTRIBUTING.md | 18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)
> 
> diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
> index 4273d99d..686ed63f 100644
> --- a/CONTRIBUTING.md
> +++ b/CONTRIBUTING.md
> @@ -55,12 +55,16 @@ Tracking patches and following up
>  ---------------------------------
>  
>  [Wayland Patchwork](http://patchwork.freedesktop.org/project/wayland/list/) is
> -used for tracking patches to Wayland and Weston. Xwayland patches are tracked
> -with the [Xorg project](https://patchwork.freedesktop.org/project/Xorg/list/)
> -instead. Libinput patches, even though they use the same mailing list as
> +used for tracking patches to Wayland. Xwayland patches are tracked with the
> +[Xorg project](https://patchwork.freedesktop.org/project/Xorg/list/)
> +instead. Weston uses
> +[GitLab merge requests](https://gitlab.freedesktop.org/wayland/weston/merge_requests)
> +for code review, and does not use mailing list review at all.
> +
> +Libinput patches, even though they use the same mailing list as
>  Wayland, are not tracked in the Wayland Patchwork.
>  
> -The following applies only to Wayland and Weston.
> +The following applies only to Wayland.
>  
>  If a patch is not found in Patchwork, there is a high possibility for it to be
>  forgotten. Patches attached to bug reports or not arriving to the mailing list
> @@ -93,8 +97,8 @@ The following patch states are found in Patchwork:
>      Request for comments, not meant to be merged as is.
>  
>  - **Not applicable**:
> -    The email was not actually a patch, or the patch is not for Wayland or
> -    Weston. Libinput patches are usually automatically ignored by Wayland
> +    The email was not actually a patch, or the patch is not for Wayland.
> +    Libinput patches are usually automatically ignored by Wayland
>      Patchwork, but if they get through, they will be marked as Not
>      applicable.
>  
> @@ -121,7 +125,7 @@ shown.
>  
>  There is also a command line interface to Patchwork called `pwclient`, see
>  http://patchwork.freedesktop.org/project/wayland/
> -for links where to get it and the sample `.pwclientrc` for Wayland/Weston.
> +for links where to get it and the sample `.pwclientrc` for Wayland.
>  
>  
>  Coding style

Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>


Thanks,
pq