drm/i915/lpe: Mark LPE audio as "no callbacks"

Submitted by Chris Wilson on Aug. 2, 2018, 2:04 p.m.

Details

Message ID 20180802140416.6062-1-chris@chris-wilson.co.uk
State Accepted
Commit 46e831abe864a6b59fa3de253a681c0f2ee1bf2f
Headers show
Series "drm/i915/lpe: Mark LPE audio as "no callbacks"" ( rev: 1 ) in Intel GFX

Not browsing as part of any series.

Commit Message

Chris Wilson Aug. 2, 2018, 2:04 p.m.
The LPE audio is a child device of i915, it is powered up and down
alongside the igfx and presents no independent runtime interface. This
aptly fulfils the description of a "No-Callback" Device, so mark it
thus.

Fixes: 183c00350ccd ("drm/i915: Fix runtime PM for LPE audio")
Testcase: igt/pm_rpm/basic-pci-d3-state
Testcase: igt/pm_rpm/basic-rte
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: stable@vger.kernel.org
---
 drivers/gpu/drm/i915/intel_lpe_audio.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/intel_lpe_audio.c b/drivers/gpu/drm/i915/intel_lpe_audio.c
index 6269750e2b54..430732720e65 100644
--- a/drivers/gpu/drm/i915/intel_lpe_audio.c
+++ b/drivers/gpu/drm/i915/intel_lpe_audio.c
@@ -126,9 +126,7 @@  lpe_audio_platdev_create(struct drm_i915_private *dev_priv)
 		return platdev;
 	}
 
-	pm_runtime_forbid(&platdev->dev);
-	pm_runtime_set_active(&platdev->dev);
-	pm_runtime_enable(&platdev->dev);
+	pm_runtime_no_callbacks(&platdev->dev);
 
 	return platdev;
 }

Comments

Quoting Chris Wilson (2018-08-02 17:04:16)
> The LPE audio is a child device of i915, it is powered up and down
> alongside the igfx and presents no independent runtime interface. This
> aptly fulfils the description of a "No-Callback" Device, so mark it
> thus.
> 
> Fixes: 183c00350ccd ("drm/i915: Fix runtime PM for LPE audio")
> Testcase: igt/pm_rpm/basic-pci-d3-state
> Testcase: igt/pm_rpm/basic-rte
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: stable@vger.kernel.org

Checks out with the documentation.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
Quoting Joonas Lahtinen (2018-08-03 10:14:48)
> Quoting Chris Wilson (2018-08-02 17:04:16)
> > The LPE audio is a child device of i915, it is powered up and down
> > alongside the igfx and presents no independent runtime interface. This
> > aptly fulfils the description of a "No-Callback" Device, so mark it
> > thus.
> > 
> > Fixes: 183c00350ccd ("drm/i915: Fix runtime PM for LPE audio")
> > Testcase: igt/pm_rpm/basic-pci-d3-state
> > Testcase: igt/pm_rpm/basic-rte
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Takashi Iwai <tiwai@suse.de>
> > Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: stable@vger.kernel.org
> 
> Checks out with the documentation.
> 
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Pushed, thanks.
-Chris