[1/3] drm/ttm: fix missed conversion of set_pages_array_uc

Submitted by Huang, Ray on Aug. 1, 2018, 5:49 a.m.

Details

Message ID 1533102573-15365-1-git-send-email-ray.huang@amd.com
State New
Headers show
Series "Series without cover letter" ( rev: 1 ) in AMD X.Org drivers

Not browsing as part of any series.

Commit Message

Huang, Ray Aug. 1, 2018, 5:49 a.m.
This patch fixed the error when do not configure CONFIG_X86, otherwise, below
error will be encountered.

All errors (new ones prefixed by >>):

   drivers/gpu/drm/ttm/ttm_page_alloc_dma.c: In function 'ttm_set_pages_caching':
>> drivers/gpu/drm/ttm/ttm_page_alloc_dma.c:272:7: error: implicit declaration of function 'set_pages_array_uc'; did you mean
+'ttm_set_pages_array_uc'? [-Werror=implicit-function-declaration]
      r = set_pages_array_uc(pages, cpages);
          ^~~~~~~~~~~~~~~~~~
          ttm_set_pages_array_uc
   cc1: some warnings being treated as errors

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Huang Rui <ray.huang@amd.com>
---
 drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
index 8304917..507be7a 100644
--- a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
+++ b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
@@ -269,7 +269,7 @@  static int ttm_set_pages_caching(struct dma_pool *pool,
 	int r = 0;
 	/* Set page caching */
 	if (pool->type & IS_UC) {
-		r = set_pages_array_uc(pages, cpages);
+		r = ttm_set_pages_array_uc(pages, cpages);
 		if (r)
 			pr_err("%s: Failed to set %d pages to uc!\n",
 			       pool->dev_name, cpages);

Comments

Am 01.08.2018 um 07:49 schrieb Huang Rui:
> This patch fixed the error when do not configure CONFIG_X86, otherwise, below
> error will be encountered.
>
> All errors (new ones prefixed by >>):
>
>     drivers/gpu/drm/ttm/ttm_page_alloc_dma.c: In function 'ttm_set_pages_caching':
>>> drivers/gpu/drm/ttm/ttm_page_alloc_dma.c:272:7: error: implicit declaration of function 'set_pages_array_uc'; did you mean
> +'ttm_set_pages_array_uc'? [-Werror=implicit-function-declaration]
>        r = set_pages_array_uc(pages, cpages);
>            ^~~~~~~~~~~~~~~~~~
>            ttm_set_pages_array_uc
>     cc1: some warnings being treated as errors
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Huang Rui <ray.huang@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com> for the series.

> ---
>   drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
> index 8304917..507be7a 100644
> --- a/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
> +++ b/drivers/gpu/drm/ttm/ttm_page_alloc_dma.c
> @@ -269,7 +269,7 @@ static int ttm_set_pages_caching(struct dma_pool *pool,
>   	int r = 0;
>   	/* Set page caching */
>   	if (pool->type & IS_UC) {
> -		r = set_pages_array_uc(pages, cpages);
> +		r = ttm_set_pages_array_uc(pages, cpages);
>   		if (r)
>   			pr_err("%s: Failed to set %d pages to uc!\n",
>   			       pool->dev_name, cpages);