[wayland-protocols,2/2] tests: Make wayland-scanner strict

Submitted by Jonas Ådahl on July 30, 2018, 3:10 p.m.

Details

Message ID 20180730151008.24421-2-jadahl@gmail.com
State Accepted
Commit 6d58be003554ae1cb253ef0b2739b496561fdc92
Headers show
Series "Series without cover letter" ( rev: 1 ) in Wayland (DEPRECATED)

Not browsing as part of any series.

Commit Message

Jonas Ådahl July 30, 2018, 3:10 p.m.
Pass --strict to wayland-scanner in order to make it exit with failure
if something wasn't correct.

Signed-off-by: Jonas Ådahl <jadahl@gmail.com>
---
 tests/scan.sh | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Patch hide | download patch | download mbox

diff --git a/tests/scan.sh b/tests/scan.sh
index 0b1ff00..cad6887 100755
--- a/tests/scan.sh
+++ b/tests/scan.sh
@@ -5,7 +5,7 @@  if [ "x$SCANNER" = "x" ] ; then
 	exit 77
 fi
 
-$SCANNER client-header $1 /dev/null
-$SCANNER server-header $1 /dev/null
-$SCANNER private-code $1 /dev/null
-$SCANNER public-code $1 /dev/null
+$SCANNER client-header --strict $1 /dev/null
+$SCANNER server-header --strict $1 /dev/null
+$SCANNER private-code --strict $1 /dev/null
+$SCANNER public-code --strict $1 /dev/null

Comments

Hi Jonas,

On Mon, 30 Jul 2018 at 16:10, Jonas Ådahl <jadahl@gmail.com> wrote:
> Pass --strict to wayland-scanner in order to make it exit with failure
> if something wasn't correct.

The series is:
Reviewed-by: Daniel Stone <daniels@collabora.com>

It might be nice to autodetect whether or not wayland-scanner is new
enough to support these, but doing that in autotools would probably be
a pain. It should be enough to just note in the commit message that
you need a newer scanner.

Cheers,
Daniel
On July 30, 2018 4:10 PM, Jonas Ådahl <jadahl@gmail.com> wrote:
> Pass --strict to wayland-scanner in order to make it exit with failure
> if something wasn't correct.
>
> Signed-off-by: Jonas Ådahl <jadahl@gmail.com>

LGTM and catches the <arg> inside <description> issue.

Reviewed-by: Simon Ser <contact@emersion.fr>

> ---
>  tests/scan.sh | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/scan.sh b/tests/scan.sh
> index 0b1ff00..cad6887 100755
> --- a/tests/scan.sh
> +++ b/tests/scan.sh
> @@ -5,7 +5,7 @@ if [ "x$SCANNER" = "x" ] ; then
>  	exit 77
>  fi
>
> -$SCANNER client-header $1 /dev/null
> -$SCANNER server-header $1 /dev/null
> -$SCANNER private-code $1 /dev/null
> -$SCANNER public-code $1 /dev/null
> +$SCANNER client-header --strict $1 /dev/null
> +$SCANNER server-header --strict $1 /dev/null
> +$SCANNER private-code --strict $1 /dev/null
> +$SCANNER public-code --strict $1 /dev/null
> --
> 2.17.1
>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel