[1/2] build: Remove execinfo.h check

Submitted by Daniel Stone on July 21, 2018, 11:13 a.m.

Details

Message ID 20180721111315.22172-2-daniels@collabora.com
State Accepted
Commit 99c3c10ad0e0a27a8c5d33d1e285e8b77fe0534b
Headers show
Series "Build system detritus removal" ( rev: 1 ) in Wayland

Not browsing as part of any series.

Commit Message

Daniel Stone July 21, 2018, 11:13 a.m.
The check for the execinfo.h header is only advisory; the build will not
fail if it is not present, and set HAVE_EXECINFO_H if it is. The check
was added in commit 5cfdbef3d299 ("build: Allow disabling building of
wayland libraries") with no obvious use or reasoning.

Remove the no-op check.

Signed-off-by: Daniel Stone <daniels@collabora.com>
---
 configure.ac | 1 -
 1 file changed, 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/configure.ac b/configure.ac
index 81cf4077..8c2fb822 100644
--- a/configure.ac
+++ b/configure.ac
@@ -109,7 +109,6 @@  if test "x$enable_libraries" = "xyes"; then
 	AC_CHECK_DECL(CLOCK_MONOTONIC,[],
 		      [AC_MSG_ERROR("CLOCK_MONOTONIC is needed to compile wayland libraries")],
 		      [[#include <time.h>]])
-	AC_CHECK_HEADERS([execinfo.h])
 fi
 
 PKG_CHECK_MODULES(EXPAT, [expat], [],

Comments

On 2018-07-21 06:13 AM, Daniel Stone wrote:
> The check for the execinfo.h header is only advisory; the build will not
> fail if it is not present, and set HAVE_EXECINFO_H if it is. The check
> was added in commit 5cfdbef3d299 ("build: Allow disabling building of
> wayland libraries") with no obvious use or reasoning.

5cfdbe3d299 just moved it, it was added in commit bc3e020475

It appears to have been accidentally included there, as it doesn't look
relevant to the bug ticket referenced in the commit.

> Remove the no-op check.
> 
> Signed-off-by: Daniel Stone <daniels@collabora.com>

Reviewed-by: Derek Foreman <derek.foreman.samsung@gmail.com>

Though, I wouldn't mind seeing a more accurate commit log. ;)

> ---
>  configure.ac | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 81cf4077..8c2fb822 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -109,7 +109,6 @@ if test "x$enable_libraries" = "xyes"; then
>  	AC_CHECK_DECL(CLOCK_MONOTONIC,[],
>  		      [AC_MSG_ERROR("CLOCK_MONOTONIC is needed to compile wayland libraries")],
>  		      [[#include <time.h>]])
> -	AC_CHECK_HEADERS([execinfo.h])
>  fi
>  
>  PKG_CHECK_MODULES(EXPAT, [expat], [],
>
On 25 July 2018 at 18:36, Derek Foreman <derek.foreman.samsung@gmail.com> wrote:
> On 2018-07-21 06:13 AM, Daniel Stone wrote:
>> The check for the execinfo.h header is only advisory; the build will not
>> fail if it is not present, and set HAVE_EXECINFO_H if it is. The check
>> was added in commit 5cfdbef3d299 ("build: Allow disabling building of
>> wayland libraries") with no obvious use or reasoning.
>
> 5cfdbe3d299 just moved it, it was added in commit bc3e020475
>
> It appears to have been accidentally included there, as it doesn't look
> relevant to the bug ticket referenced in the commit.
>
>> Remove the no-op check.
>>
>> Signed-off-by: Daniel Stone <daniels@collabora.com>
>
> Reviewed-by: Derek Foreman <derek.foreman.samsung@gmail.com>
>
> Though, I wouldn't mind seeing a more accurate commit log. ;)
>
It's always better to not get called out for other's copy/paste
mistakes. If you guys like Fixes tags, here is one

Fixes: bc3e020475e ("build: Add declaration checks to check for
required syscall flags")

Fwiw, series is
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>

-Emil
Hi,

On Thu, 26 Jul 2018 at 16:11, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> On 25 July 2018 at 18:36, Derek Foreman <derek.foreman.samsung@gmail.com> wrote:
> > On 2018-07-21 06:13 AM, Daniel Stone wrote:
> >> The check for the execinfo.h header is only advisory; the build will not
> >> fail if it is not present, and set HAVE_EXECINFO_H if it is. The check
> >> was added in commit 5cfdbef3d299 ("build: Allow disabling building of
> >> wayland libraries") with no obvious use or reasoning.
> >
> > 5cfdbe3d299 just moved it, it was added in commit bc3e020475
> >
> > It appears to have been accidentally included there, as it doesn't look
> > relevant to the bug ticket referenced in the commit.
> >
> >> Remove the no-op check.
> >>
> >> Signed-off-by: Daniel Stone <daniels@collabora.com>
> >
> > Reviewed-by: Derek Foreman <derek.foreman.samsung@gmail.com>
> >
> > Though, I wouldn't mind seeing a more accurate commit log. ;)
> >
> It's always better to not get called out for other's copy/paste
> mistakes. If you guys like Fixes tags, here is one
>
> Fixes: bc3e020475e ("build: Add declaration checks to check for
> required syscall flags")
>
> Fwiw, series is
> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>

Thanks both for the review and accuracy check: I've pushed both patches now.

Cheers,
Daniel