[v3,1/3] xdg-shell: move maximized state definition together

Submitted by wl@ongy.net on July 20, 2018, 9:09 a.m.

Details

Message ID 20180720090934.10308-2-wl@ongy.net
State Accepted
Commit 31236887df15523538736561a855dd90bc5baeb4
Headers show
Series "Change wording in xdg-shell stable" ( rev: 2 ) in Wayland

Not browsing as part of any series.

Commit Message

wl@ongy.net July 20, 2018, 9:09 a.m.
From: Markus Ongyerth <wl@ongy.net>

The xdg-shell documentation had part of the maximized state render
implications in the `set_maximized` request documentation, not the
actual state.
This moves the relevant lines into the state description.

Signed-off-by: Markus Ongyerth <wl@ongy.net>
Reviewed-By: Mike Blumenkrantz <zmike@osg.samsung.com>
---
 stable/xdg-shell/xdg-shell.xml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/stable/xdg-shell/xdg-shell.xml b/stable/xdg-shell/xdg-shell.xml
index ad96fe8..213b227 100644
--- a/stable/xdg-shell/xdg-shell.xml
+++ b/stable/xdg-shell/xdg-shell.xml
@@ -724,6 +724,9 @@ 
 	<description summary="the surface is maximized">
 	  The surface is maximized. The window geometry specified in the configure
 	  event must be obeyed by the client.
+
+	  The client should draw without shadow or other
+	  decoration outside of the window geometry.
 	</description>
       </entry>
       <entry name="fullscreen" value="2" summary="the surface is fullscreen">
@@ -865,8 +868,7 @@ 
 	After requesting that the surface should be maximized, the compositor
 	will respond by emitting a configure event with the "maximized" state
 	and the required window geometry. The client should then update its
-	content, drawing it in a maximized state, i.e. without shadow or other
-	decoration outside of the window geometry. The client must also
+	content, drawing it in a maximized state. The client must also
 	acknowledge the configure when committing the new content (see
 	ack_configure).
 

Comments

On July 20, 2018 10:09 AM, <wl@ongy.net> wrote:
> From: Markus Ongyerth <wl@ongy.net>
>
> The xdg-shell documentation had part of the maximized state render
> implications in the `set_maximized` request documentation, not the
> actual state.
> This moves the relevant lines into the state description.
>
> Signed-off-by: Markus Ongyerth <wl@ongy.net>
> Reviewed-By: Mike Blumenkrantz <zmike@osg.samsung.com>

Reviewed-By: Simon Ser <contact@emersion.fr>

> ---
>  stable/xdg-shell/xdg-shell.xml | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/stable/xdg-shell/xdg-shell.xml b/stable/xdg-shell/xdg-shell.xml
> index ad96fe8..213b227 100644
> --- a/stable/xdg-shell/xdg-shell.xml
> +++ b/stable/xdg-shell/xdg-shell.xml
> @@ -724,6 +724,9 @@
>  	<description summary="the surface is maximized">
>  	  The surface is maximized. The window geometry specified in the configure
>  	  event must be obeyed by the client.
> +
> +	  The client should draw without shadow or other
> +	  decoration outside of the window geometry.
>  	</description>
>        </entry>
>        <entry name="fullscreen" value="2" summary="the surface is fullscreen">
> @@ -865,8 +868,7 @@
>  	After requesting that the surface should be maximized, the compositor
>  	will respond by emitting a configure event with the "maximized" state
>  	and the required window geometry. The client should then update its
> -	content, drawing it in a maximized state, i.e. without shadow or other
> -	decoration outside of the window geometry. The client must also
> +	content, drawing it in a maximized state. The client must also
>  	acknowledge the configure when committing the new content (see
>  	ack_configure).
>
> --
> 2.18.0
>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel