glamor: Invalidate cached GEM handle in radeon_set_pixmap_bo

Submitted by Michel Dänzer on July 17, 2018, 9:43 a.m.

Details

Message ID 20180717094346.14109-1-michel@daenzer.net
State Accepted
Commit 499d2f9d5d301ef1efd4ffc2952677609ef05122
Headers show
Series "glamor: Invalidate cached GEM handle in radeon_set_pixmap_bo" ( rev: 1 ) in AMD X.Org drivers

Not browsing as part of any series.

Commit Message

Michel Dänzer July 17, 2018, 9:43 a.m. 
From: Michel Dänzer <michel.daenzer@amd.com>

We continued using the stale cached handle, causing issues e.g. when
resizing the screen via RandR.

Reported-by: iive on IRC
Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
---
 src/radeon.h | 1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox 

diff --git a/src/radeon.h b/src/radeon.h
index 450c69aa8..1a1edb1ba 100644
--- a/src/radeon.h
+++ b/src/radeon.h
@@ -735,6 +735,7 @@  static inline Bool radeon_set_pixmap_bo(PixmapPtr pPix, struct radeon_buffer *bo
 		    return TRUE;
 
 		radeon_buffer_unref(&priv->bo);
+		priv->handle_valid = FALSE;
 	    }
 
 	    drmmode_fb_reference(pRADEONEnt->fd, &priv->fb, NULL);

Comments

Alex Deucher July 17, 2018, 3:43 p.m. 
On Tue, Jul 17, 2018 at 5:43 AM, Michel Dänzer <michel@daenzer.net> wrote:
> From: Michel Dänzer <michel.daenzer@amd.com>
>
> We continued using the stale cached handle, causing issues e.g. when
> resizing the screen via RandR.
>
> Reported-by: iive on IRC
> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>

Acked-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  src/radeon.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/radeon.h b/src/radeon.h
> index 450c69aa8..1a1edb1ba 100644
> --- a/src/radeon.h
> +++ b/src/radeon.h
> @@ -735,6 +735,7 @@ static inline Bool radeon_set_pixmap_bo(PixmapPtr pPix, struct radeon_buffer *bo
>                     return TRUE;
>
>                 radeon_buffer_unref(&priv->bo);
> +               priv->handle_valid = FALSE;
>             }
>
>             drmmode_fb_reference(pRADEONEnt->fd, &priv->fb, NULL);
> --
> 2.18.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx