[1/2] drm/amdgpu: fix 'ISO C90 forbids mixed declarations'

Submitted by Zhou, David(ChunMing) on May 30, 2018, 3:14 a.m.

Details

Message ID 20180530031447.27119-1-david1.zhou@amd.com
State New
Headers show
Series "Series without cover letter" ( rev: 1 ) in AMD X.Org drivers

Not browsing as part of any series.

Commit Message

Zhou, David(ChunMing) May 30, 2018, 3:14 a.m.
Change-Id: I412f5783e2839c53841e6ab665f939236bdc5bf1
Signed-off-by: Chunming Zhou <david1.zhou@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
index 9ea8fb077aba..12f0d18c6ee8 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
@@ -657,12 +657,12 @@  static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,
 				     p->bytes_moved_vis);
 
 	if (p->bo_list) {
-		gds = p->bo_list->gds_obj;
-		gws = p->bo_list->gws_obj;
-		oa = p->bo_list->oa_obj;
 		struct amdgpu_vm *vm = &fpriv->vm;
 		unsigned i;
 
+		gds = p->bo_list->gds_obj;
+		gws = p->bo_list->gws_obj;
+		oa = p->bo_list->oa_obj;
 		for (i = 0; i < p->bo_list->num_entries; i++) {
 			struct amdgpu_bo *bo = p->bo_list->array[i].robj;
 

Comments

Reviewed-by: Emily Deng <Emily.Deng@amd.com>


> -----Original Message-----

> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf

> Of Chunming Zhou

> Sent: Wednesday, May 30, 2018 11:15 AM

> To: dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org

> Cc: Deng, Emily <Emily.Deng@amd.com>; Zhou, David(ChunMing)

> <David1.Zhou@amd.com>

> Subject: [PATCH 1/2] drm/amdgpu: fix 'ISO C90 forbids mixed declarations'

> 

> Change-Id: I412f5783e2839c53841e6ab665f939236bdc5bf1

> Signed-off-by: Chunming Zhou <david1.zhou@amd.com>

> ---

>  drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +++---

>  1 file changed, 3 insertions(+), 3 deletions(-)

> 

> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c

> b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c

> index 9ea8fb077aba..12f0d18c6ee8 100644

> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c

> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c

> @@ -657,12 +657,12 @@ static int amdgpu_cs_parser_bos(struct

> amdgpu_cs_parser *p,

>  				     p->bytes_moved_vis);

> 

>  	if (p->bo_list) {

> -		gds = p->bo_list->gds_obj;

> -		gws = p->bo_list->gws_obj;

> -		oa = p->bo_list->oa_obj;

>  		struct amdgpu_vm *vm = &fpriv->vm;

>  		unsigned i;

> 

> +		gds = p->bo_list->gds_obj;

> +		gws = p->bo_list->gws_obj;

> +		oa = p->bo_list->oa_obj;

>  		for (i = 0; i < p->bo_list->num_entries; i++) {

>  			struct amdgpu_bo *bo = p->bo_list->array[i].robj;

> 

> --

> 2.14.1

> 

> _______________________________________________

> amd-gfx mailing list

> amd-gfx@lists.freedesktop.org

> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Please add something like "Fixing a compiler warning." as commit message.

With that done the series is Reviewed-by: Christian König 
<christian.koenig@amd.com>.

Thanks,
Christian.

Am 30.05.2018 um 05:14 schrieb Chunming Zhou:
> Change-Id: I412f5783e2839c53841e6ab665f939236bdc5bf1
> Signed-off-by: Chunming Zhou <david1.zhou@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index 9ea8fb077aba..12f0d18c6ee8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -657,12 +657,12 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,
>   				     p->bytes_moved_vis);
>   
>   	if (p->bo_list) {
> -		gds = p->bo_list->gds_obj;
> -		gws = p->bo_list->gws_obj;
> -		oa = p->bo_list->oa_obj;
>   		struct amdgpu_vm *vm = &fpriv->vm;
>   		unsigned i;
>   
> +		gds = p->bo_list->gds_obj;
> +		gws = p->bo_list->gws_obj;
> +		oa = p->bo_list->oa_obj;
>   		for (i = 0; i < p->bo_list->num_entries; i++) {
>   			struct amdgpu_bo *bo = p->bo_list->array[i].robj;
>