[Mesa-dev] mesa: fix type-P format examples to match actual formats

Submitted by Chris Forbes on March 19, 2014, 9:34 a.m.

Details

Message ID 1395221665-11770-1-git-send-email-chrisf@ijw.co.nz
State New
Headers show

Not browsing as part of any series.

Commit Message

Chris Forbes March 19, 2014, 9:34 a.m.
The comments for the actual formats were fixed a while ago,
but the examples at the top were not, which was confusing.

Signed-off-by: Chris Forbes <chrisf@ijw.co.nz>
---
 src/mesa/main/formats.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/mesa/main/formats.h b/src/mesa/main/formats.h
index 3079f03..0ca495e 100644
--- a/src/mesa/main/formats.h
+++ b/src/mesa/main/formats.h
@@ -114,9 +114,9 @@  typedef enum
     *   ** when type applies to all components
     *
     *  examples:                   msb <------ TEXEL BITS -----------> lsb
-    *  MESA_FORMAT_A8B8G8R8_UNORM, AAAA AAAA BBBB BBBB GGGG GGGG RRRR RRRR
-    *  MESA_FORMAT_R5G6B5_UNORM                        RRRR RGGG GGGB BBBB
-    *  MESA_FORMAT_B4G4R4X4_UNORM                      BBBB GGGG RRRR XXXX
+    *  MESA_FORMAT_A8B8G8R8_UNORM, RRRR RRRR GGGG GGGG BBBB BBBB AAAA AAAA
+    *  MESA_FORMAT_R5G6B5_UNORM                        BBBB BGGG GGGR RRRR
+    *  MESA_FORMAT_B4G4R4X4_UNORM                      xxxx RRRR GGGG BBBB
     *  MESA_FORMAT_Z32_FLOAT_S8X24_UINT
     *  MESA_FORMAT_R10G10B10A2_UINT
     *  MESA_FORMAT_R9G9B9E5_FLOAT

Comments

Are these comments really needed considering the format names are
self-explanatory?

Marek

On Wed, Mar 19, 2014 at 10:34 AM, Chris Forbes <chrisf@ijw.co.nz> wrote:
> The comments for the actual formats were fixed a while ago,
> but the examples at the top were not, which was confusing.
>
> Signed-off-by: Chris Forbes <chrisf@ijw.co.nz>
> ---
>  src/mesa/main/formats.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/mesa/main/formats.h b/src/mesa/main/formats.h
> index 3079f03..0ca495e 100644
> --- a/src/mesa/main/formats.h
> +++ b/src/mesa/main/formats.h
> @@ -114,9 +114,9 @@ typedef enum
>      *   ** when type applies to all components
>      *
>      *  examples:                   msb <------ TEXEL BITS -----------> lsb
> -    *  MESA_FORMAT_A8B8G8R8_UNORM, AAAA AAAA BBBB BBBB GGGG GGGG RRRR RRRR
> -    *  MESA_FORMAT_R5G6B5_UNORM                        RRRR RGGG GGGB BBBB
> -    *  MESA_FORMAT_B4G4R4X4_UNORM                      BBBB GGGG RRRR XXXX
> +    *  MESA_FORMAT_A8B8G8R8_UNORM, RRRR RRRR GGGG GGGG BBBB BBBB AAAA AAAA
> +    *  MESA_FORMAT_R5G6B5_UNORM                        BBBB BGGG GGGR RRRR
> +    *  MESA_FORMAT_B4G4R4X4_UNORM                      xxxx RRRR GGGG BBBB
>      *  MESA_FORMAT_Z32_FLOAT_S8X24_UINT
>      *  MESA_FORMAT_R10G10B10A2_UINT
>      *  MESA_FORMAT_R9G9B9E5_FLOAT
> --
> 1.9.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
I'd be fine with removing/reducing the comments.

-Brian

On 03/19/2014 05:45 AM, Marek Olšák wrote:
> Are these comments really needed considering the format names are
> self-explanatory?
>
> Marek
>
> On Wed, Mar 19, 2014 at 10:34 AM, Chris Forbes <chrisf@ijw.co.nz> wrote:
>> The comments for the actual formats were fixed a while ago,
>> but the examples at the top were not, which was confusing.
>>
>> Signed-off-by: Chris Forbes <chrisf@ijw.co.nz>
>> ---
>>   src/mesa/main/formats.h | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/mesa/main/formats.h b/src/mesa/main/formats.h
>> index 3079f03..0ca495e 100644
>> --- a/src/mesa/main/formats.h
>> +++ b/src/mesa/main/formats.h
>> @@ -114,9 +114,9 @@ typedef enum
>>       *   ** when type applies to all components
>>       *
>>       *  examples:                   msb <------ TEXEL BITS -----------> lsb
>> -    *  MESA_FORMAT_A8B8G8R8_UNORM, AAAA AAAA BBBB BBBB GGGG GGGG RRRR RRRR
>> -    *  MESA_FORMAT_R5G6B5_UNORM                        RRRR RGGG GGGB BBBB
>> -    *  MESA_FORMAT_B4G4R4X4_UNORM                      BBBB GGGG RRRR XXXX
>> +    *  MESA_FORMAT_A8B8G8R8_UNORM, RRRR RRRR GGGG GGGG BBBB BBBB AAAA AAAA
>> +    *  MESA_FORMAT_R5G6B5_UNORM                        BBBB BGGG GGGR RRRR
>> +    *  MESA_FORMAT_B4G4R4X4_UNORM                      xxxx RRRR GGGG BBBB
>>       *  MESA_FORMAT_Z32_FLOAT_S8X24_UINT
>>       *  MESA_FORMAT_R10G10B10A2_UINT
>>       *  MESA_FORMAT_R9G9B9E5_FLOAT
>> --
>> 1.9.0
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev@lists.freedesktop.org
>> https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/mesa-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=lGQMzzTgII0I7jefp2FHq7WtZ%2BTLs8wadB%2BiIj9xpBY%3D%0A&m=2kaU%2BGk8T5bvGCIVgZgk3ZUABxjJAi7RzOav%2FnyeqFE%3D%0A&s=fdf1cfc0f8de578c6a44e6edef6709057d647becff667b8a66771a1685580277
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/mesa-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=lGQMzzTgII0I7jefp2FHq7WtZ%2BTLs8wadB%2BiIj9xpBY%3D%0A&m=2kaU%2BGk8T5bvGCIVgZgk3ZUABxjJAi7RzOav%2FnyeqFE%3D%0A&s=fdf1cfc0f8de578c6a44e6edef6709057d647becff667b8a66771a1685580277
>