[CI,TEST] igt/tests/kms_plane_multiple: Disable framebuffer compression

Submitted by Mika Kahola on May 14, 2018, 11:43 a.m.

Details

Message ID 1526298188-7448-1-git-send-email-mika.kahola@intel.com
State New
Headers show
Series "igt/tests/kms_plane_multiple: Disable framebuffer compression" ( rev: 1 ) in IGT

Not browsing as part of any series.

Commit Message

Mika Kahola May 14, 2018, 11:43 a.m.
Disable framebuffer compression when execution test with multiple planes.

Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
 tests/kms_plane_multiple.c | 7 +++++++
 1 file changed, 7 insertions(+)

Patch hide | download patch | download mbox

diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
index e61bc84..9ae2756 100644
--- a/tests/kms_plane_multiple.c
+++ b/tests/kms_plane_multiple.c
@@ -36,6 +36,9 @@  IGT_TEST_DESCRIPTION("Test atomic mode setting with multiple planes ");
 #define SIZE_CURSOR     128
 #define LOOP_FOREVER     -1
 
+#define fbc_enable() igt_set_module_param_int("enable_fbc", 1)
+#define fbc_disable() igt_set_module_param_int("enable_fbc", 0)
+
 typedef struct {
 	float red;
 	float green;
@@ -67,6 +70,8 @@  struct {
  */
 static void test_init(data_t *data, enum pipe pipe, int n_planes)
 {
+	fbc_disable();
+
 	data->pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe, INTEL_PIPE_CRC_SOURCE_AUTO);
 
 	data->plane = calloc(n_planes, sizeof(data->plane));
@@ -102,6 +107,8 @@  static void test_fini(data_t *data, igt_output_t *output, int n_planes)
 	igt_remove_fb(data->drm_fd, data->fb);
 
 	igt_display_reset(&data->display);
+
+	fbc_enable();
 }
 
 static void

Comments

On Mon, May 14, 2018 at 02:43:08PM +0300, Mika Kahola wrote:
> Disable framebuffer compression when execution test with multiple planes.

Why?

> 
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> ---
>  tests/kms_plane_multiple.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
> index e61bc84..9ae2756 100644
> --- a/tests/kms_plane_multiple.c
> +++ b/tests/kms_plane_multiple.c
> @@ -36,6 +36,9 @@ IGT_TEST_DESCRIPTION("Test atomic mode setting with multiple planes ");
>  #define SIZE_CURSOR     128
>  #define LOOP_FOREVER     -1
>  
> +#define fbc_enable() igt_set_module_param_int("enable_fbc", 1)
> +#define fbc_disable() igt_set_module_param_int("enable_fbc", 0)
> +
>  typedef struct {
>  	float red;
>  	float green;
> @@ -67,6 +70,8 @@ struct {
>   */
>  static void test_init(data_t *data, enum pipe pipe, int n_planes)
>  {
> +	fbc_disable();
> +
>  	data->pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe, INTEL_PIPE_CRC_SOURCE_AUTO);
>  
>  	data->plane = calloc(n_planes, sizeof(data->plane));
> @@ -102,6 +107,8 @@ static void test_fini(data_t *data, igt_output_t *output, int n_planes)
>  	igt_remove_fb(data->drm_fd, data->fb);
>  
>  	igt_display_reset(&data->display);
> +
> +	fbc_enable();
>  }
>  
>  static void
> -- 
> 2.7.4
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
On Tue, 2018-05-15 at 18:19 +0300, Ville Syrjälä wrote:
> On Mon, May 14, 2018 at 02:43:08PM +0300, Mika Kahola wrote:
> > 
> > Disable framebuffer compression when execution test with multiple
> > planes.
> Why?
Just a test to check if fbc has anything to do with pipe crc mismatch
errors that we keep receiving from CI runs.
> 
> > 
> > 
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > ---
> >  tests/kms_plane_multiple.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/tests/kms_plane_multiple.c
> > b/tests/kms_plane_multiple.c
> > index e61bc84..9ae2756 100644
> > --- a/tests/kms_plane_multiple.c
> > +++ b/tests/kms_plane_multiple.c
> > @@ -36,6 +36,9 @@ IGT_TEST_DESCRIPTION("Test atomic mode setting
> > with multiple planes ");
> >  #define SIZE_CURSOR     128
> >  #define LOOP_FOREVER     -1
> >  
> > +#define fbc_enable() igt_set_module_param_int("enable_fbc", 1)
> > +#define fbc_disable() igt_set_module_param_int("enable_fbc", 0)
> > +
> >  typedef struct {
> >  	float red;
> >  	float green;
> > @@ -67,6 +70,8 @@ struct {
> >   */
> >  static void test_init(data_t *data, enum pipe pipe, int n_planes)
> >  {
> > +	fbc_disable();
> > +
> >  	data->pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe,
> > INTEL_PIPE_CRC_SOURCE_AUTO);
> >  
> >  	data->plane = calloc(n_planes, sizeof(data->plane));
> > @@ -102,6 +107,8 @@ static void test_fini(data_t *data,
> > igt_output_t *output, int n_planes)
> >  	igt_remove_fb(data->drm_fd, data->fb);
> >  
> >  	igt_display_reset(&data->display);
> > +
> > +	fbc_enable();
> >  }
> >  
> >  static void
> > -- 
> > 2.7.4
> > 
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
On Wed, 2018-05-16 at 09:11 +0300, Mika Kahola wrote:
> On Tue, 2018-05-15 at 18:19 +0300, Ville Syrjälä wrote:
> > 
> > On Mon, May 14, 2018 at 02:43:08PM +0300, Mika Kahola wrote:
> > > 
> > > 
> > > Disable framebuffer compression when execution test with multiple
> > > planes.
> > Why?
> Just a test to check if fbc has anything to do with pipe crc mismatch
> errors that we keep receiving from CI runs.
Well, based on shard runs, fbc has nothing to do with crc mismatch
errors on glk.

> > 
> > 
> > > 
> > > 
> > > 
> > > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > > ---
> > >  tests/kms_plane_multiple.c | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > > 
> > > diff --git a/tests/kms_plane_multiple.c
> > > b/tests/kms_plane_multiple.c
> > > index e61bc84..9ae2756 100644
> > > --- a/tests/kms_plane_multiple.c
> > > +++ b/tests/kms_plane_multiple.c
> > > @@ -36,6 +36,9 @@ IGT_TEST_DESCRIPTION("Test atomic mode setting
> > > with multiple planes ");
> > >  #define SIZE_CURSOR     128
> > >  #define LOOP_FOREVER     -1
> > >  
> > > +#define fbc_enable() igt_set_module_param_int("enable_fbc", 1)
> > > +#define fbc_disable() igt_set_module_param_int("enable_fbc", 0)
> > > +
> > >  typedef struct {
> > >  	float red;
> > >  	float green;
> > > @@ -67,6 +70,8 @@ struct {
> > >   */
> > >  static void test_init(data_t *data, enum pipe pipe, int
> > > n_planes)
> > >  {
> > > +	fbc_disable();
> > > +
> > >  	data->pipe_crc = igt_pipe_crc_new(data->drm_fd, pipe,
> > > INTEL_PIPE_CRC_SOURCE_AUTO);
> > >  
> > >  	data->plane = calloc(n_planes, sizeof(data->plane));
> > > @@ -102,6 +107,8 @@ static void test_fini(data_t *data,
> > > igt_output_t *output, int n_planes)
> > >  	igt_remove_fb(data->drm_fd, data->fb);
> > >  
> > >  	igt_display_reset(&data->display);
> > > +
> > > +	fbc_enable();
> > >  }
> > >  
> > >  static void
> > > -- 
> > > 2.7.4
> > > 
> > > _______________________________________________
> > > igt-dev mailing list
> > > igt-dev@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/igt-dev