glsl-uniform-initializer-7: Fixed uninitialized uniform.

Submitted by Mathias Fröhlich on May 10, 2018, 7:01 a.m.

Details

Message ID 20180510070135.3916-1-Mathias.Froehlich@gmx.net
State Accepted
Commit 3ba0657bff4216d1ec7179935590261855f1651e
Headers show
Series "glsl-uniform-initializer-7: Fixed uninitialized uniform." ( rev: 1 ) in Piglit

Not browsing as part of any series.

Commit Message

Mathias Fröhlich May 10, 2018, 7:01 a.m.
From: Mathias Fröhlich <Mathias.Froehlich@gmx.net>

Hi all,

please review, and push if ok!

best

Mathias




This fixes a valgrind error in executing shader_runner on this test.

Signed-off-by: Mathias Fröhlich <Mathias.Froehlich@web.de>
---
 tests/shaders/glsl-uniform-initializer-7.shader_test | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/tests/shaders/glsl-uniform-initializer-7.shader_test b/tests/shaders/glsl-uniform-initializer-7.shader_test
index 4d6f28f67..135b30853 100644
--- a/tests/shaders/glsl-uniform-initializer-7.shader_test
+++ b/tests/shaders/glsl-uniform-initializer-7.shader_test
@@ -24,6 +24,6 @@  void main()
 }
 
 [test]
-uniform vec4 color 1.0 0.0 0.5
+uniform vec4 color 1.0 0.0 0.5 1.0
 draw rect -1 -1 2 2
 probe all rgba 0.0 1.0 0.5 0.0

Comments

Mathias.Froehlich@gmx.net writes:

> From: Mathias Fröhlich <Mathias.Froehlich@gmx.net>
>
> Hi all,
>
> please review, and push if ok!
>
> best
>
> Mathias
>
>
>
>
> This fixes a valgrind error in executing shader_runner on this test.

Reviewed-by: Eric Anholt <eric@anholt.net>

And you also have piglit push access now, not sure how that was missed.
Hi Eric,

On Thursday, 10 May 2018 18:17:40 CEST Eric Anholt wrote:
> Reviewed-by: Eric Anholt <eric@anholt.net>
Thanks!

> And you also have piglit push access now, not sure how that was missed.
And thanks as well.

I beileve, my initial request for commit rights contained only 'mesa' in its
wording in bugzilla, so consequently only mesa was added. Well, the discussion
on the list was also about 'mesa' and I did not know want this 'term' includes finally ...
But its probably easier in the future like that!

best
Mathias