drm/amd/display: clean up assignment of amdgpu_crtc

Submitted by Colin King on May 2, 2018, 2:43 p.m.

Details

Message ID 20180502144316.32056-1-colin.king@canonical.com
State New
Headers show
Series "drm/amd/display: clean up assignment of amdgpu_crtc" ( rev: 1 ) in DRI devel

Not browsing as part of any series.

Commit Message

Colin King May 2, 2018, 2:43 p.m.
From: Colin Ian King <colin.king@canonical.com>

The declaration of pointer amdgpu_crtc has a redundant assignment to
amdgpu_crtc. Clean this up by removing it.

Detected by CoverityScan, CID#1460299 ("Evaluation order violation")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 1dd1142246c2..2beb8821e19e 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -3773,7 +3773,7 @@  static void remove_stream(struct amdgpu_device *adev,
 static int get_cursor_position(struct drm_plane *plane, struct drm_crtc *crtc,
 			       struct dc_cursor_position *position)
 {
-	struct amdgpu_crtc *amdgpu_crtc = amdgpu_crtc = to_amdgpu_crtc(crtc);
+	struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc);
 	int x, y;
 	int xorigin = 0, yorigin = 0;
 

Comments

On 2018-05-02 10:43 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The declaration of pointer amdgpu_crtc has a redundant assignment to
> amdgpu_crtc. Clean this up by removing it.
> 
> Detected by CoverityScan, CID#1460299 ("Evaluation order violation")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Looks like i goofed. Thanks for fixing this.

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 1dd1142246c2..2beb8821e19e 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -3773,7 +3773,7 @@ static void remove_stream(struct amdgpu_device *adev,
>  static int get_cursor_position(struct drm_plane *plane, struct drm_crtc *crtc,
>  			       struct dc_cursor_position *position)
>  {
> -	struct amdgpu_crtc *amdgpu_crtc = amdgpu_crtc = to_amdgpu_crtc(crtc);
> +	struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc);
>  	int x, y;
>  	int xorigin = 0, yorigin = 0;
>  
>
On Wed, May 2, 2018 at 11:04 AM, Harry Wentland <harry.wentland@amd.com> wrote:
> On 2018-05-02 10:43 AM, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The declaration of pointer amdgpu_crtc has a redundant assignment to
>> amdgpu_crtc. Clean this up by removing it.
>>
>> Detected by CoverityScan, CID#1460299 ("Evaluation order violation")
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Looks like i goofed. Thanks for fixing this.
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>


Applied.  Thanks!

Alex

>
> Harry
>
>> ---
>>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> index 1dd1142246c2..2beb8821e19e 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> @@ -3773,7 +3773,7 @@ static void remove_stream(struct amdgpu_device *adev,
>>  static int get_cursor_position(struct drm_plane *plane, struct drm_crtc *crtc,
>>                              struct dc_cursor_position *position)
>>  {
>> -     struct amdgpu_crtc *amdgpu_crtc = amdgpu_crtc = to_amdgpu_crtc(crtc);
>> +     struct amdgpu_crtc *amdgpu_crtc = to_amdgpu_crtc(crtc);
>>       int x, y;
>>       int xorigin = 0, yorigin = 0;
>>
>>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx