Add name event to xdg-output

Submitted by Drew DeVault on April 7, 2018, 6:01 p.m.

Details

Message ID 20180407180103.19070-1-sir@cmpwn.com
State Superseded
Headers show
Series "Add name event to xdg-output" ( rev: 1 ) in Wayland

Not browsing as part of any series.

Commit Message

Drew DeVault April 7, 2018, 6:01 p.m.
Signed-off-by: Drew DeVault <sir@cmpwn.com>
Reviewed-by: Simon Ser <contact@emersion.fr>
---
 unstable/xdg-output/xdg-output-unstable-v1.xml | 11 +++++++++++
 1 file changed, 11 insertions(+)

Patch hide | download patch | download mbox

diff --git a/unstable/xdg-output/xdg-output-unstable-v1.xml b/unstable/xdg-output/xdg-output-unstable-v1.xml
index 0c0c481..65623f0 100644
--- a/unstable/xdg-output/xdg-output-unstable-v1.xml
+++ b/unstable/xdg-output/xdg-output-unstable-v1.xml
@@ -147,6 +147,17 @@ 
 	   summary="height in global compositor space"/>
     </event>
 
+    <event name="name">
+      <description summary="name of this output">
+    Many compositors will assign names to their outputs, show them to the user,
+    allow them to be configured by name, etc. The client may wish to know this
+    name as well to offer the user similar behaviors.
+
+    The name event is sent after creating an xdg_output (see
+    xdg_output_manager.get_xdg_output).
+      </description>
+    </event>
+
     <event name="done">
       <description summary="all information about the output have been sent">
 	This event is sent after all other properties of an xdg_output

Comments

Hi all,

On 7 April 2018 at 19:01, Drew DeVault <sir@cmpwn.com> wrote:
> +    <event name="name">
> +      <description summary="name of this output">
> +    Many compositors will assign names to their outputs, show them to the user,
> +    allow them to be configured by name, etc. The client may wish to know this
> +    name as well to offer the user similar behaviors.
> +
> +    The name event is sent after creating an xdg_output (see
> +    xdg_output_manager.get_xdg_output).
> +      </description>
> +    </event>

A name event would be great, but this is missing a string param to
carry the actual name.

In order to not breaking existing clients, it also needs to:
  - come after the 'done' event so we don't renumber events
  - bump the xdg_output interface version
  - annotate the event with a 'since' version attrib

Cheers,
Daniel
On 2018-04-08  3:22 PM, Daniel Stone wrote:
> A name event would be great, but this is missing a string param to
> carry the actual name.

Whoops!

> In order to not breaking existing clients, it also needs to:
>   - come after the 'done' event so we don't renumber events
>   - bump the xdg_output interface version
>   - annotate the event with a 'since' version attrib

Ah, yep. v2 shortly.