radv: disable TC-compat HTILE on Tonga and Iceland

Submitted by Samuel Pitoiset on April 5, 2018, 8:32 a.m.

Details

Message ID 20180405083241.1535-1-samuel.pitoiset@gmail.com
State New
Headers show
Series "radv: disable TC-compat HTILE on Tonga and Iceland" ( rev: 1 ) in Mesa

Not browsing as part of any series.

Commit Message

Samuel Pitoiset April 5, 2018, 8:32 a.m.
Ported from RadeonSI.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
---
 src/amd/vulkan/radv_image.c | 5 +++++
 1 file changed, 5 insertions(+)

Patch hide | download patch | download mbox

diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
index dd3189c67d..44caf0eeae 100644
--- a/src/amd/vulkan/radv_image.c
+++ b/src/amd/vulkan/radv_image.c
@@ -72,6 +72,11 @@  radv_image_is_tc_compat_htile(struct radv_device *device,
 	if (device->physical_device->rad_info.chip_class < VI)
 		return false;
 
+	/* TC-compat HTILE seems buggy on Tonga/Iceland. */
+	if (device->physical_device->rad_info.family == CHIP_TONGA ||
+	    device->physical_device->rad_info.family == CHIP_ICELAND)
+		return false;
+
 	if (pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT)
 		return false;
 

Comments

On Thu, Apr 5, 2018 at 10:32 AM, Samuel Pitoiset
<samuel.pitoiset@gmail.com> wrote:
> Ported from RadeonSI.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
> ---
>  src/amd/vulkan/radv_image.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
> index dd3189c67d..44caf0eeae 100644
> --- a/src/amd/vulkan/radv_image.c
> +++ b/src/amd/vulkan/radv_image.c
> @@ -72,6 +72,11 @@ radv_image_is_tc_compat_htile(struct radv_device *device,
>         if (device->physical_device->rad_info.chip_class < VI)
>                 return false;
>
> +       /* TC-compat HTILE seems buggy on Tonga/Iceland. */

Can we please get a reference on what seems buggy about it? This could
very well something that is done incorrectly,s o I'd like something to
check to see if that is fixed.

> +       if (device->physical_device->rad_info.family == CHIP_TONGA ||
> +           device->physical_device->rad_info.family == CHIP_ICELAND)
> +               return false;
> +
>         if (pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT)
>                 return false;
>
> --
> 2.16.3
>
On 04/05/2018 01:18 PM, Bas Nieuwenhuizen wrote:
> On Thu, Apr 5, 2018 at 10:32 AM, Samuel Pitoiset
> <samuel.pitoiset@gmail.com> wrote:
>> Ported from RadeonSI.
>>
>> Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
>> ---
>>   src/amd/vulkan/radv_image.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
>> index dd3189c67d..44caf0eeae 100644
>> --- a/src/amd/vulkan/radv_image.c
>> +++ b/src/amd/vulkan/radv_image.c
>> @@ -72,6 +72,11 @@ radv_image_is_tc_compat_htile(struct radv_device *device,
>>          if (device->physical_device->rad_info.chip_class < VI)
>>                  return false;
>>
>> +       /* TC-compat HTILE seems buggy on Tonga/Iceland. */
> 
> Can we please get a reference on what seems buggy about it? This could
> very well something that is done incorrectly,s o I'd like something to
> check to see if that is fixed.

It's a hardware bug apparently. If you have a Tonga or Iceland card, 
feel free to launch CTS with/without this patch.

I can improve the comment as well.

> 
>> +       if (device->physical_device->rad_info.family == CHIP_TONGA ||
>> +           device->physical_device->rad_info.family == CHIP_ICELAND)
>> +               return false;
>> +
>>          if (pCreateInfo->usage & VK_IMAGE_USAGE_STORAGE_BIT)
>>                  return false;
>>
>> --
>> 2.16.3
>>