Skip font-variations test for missing fonts

Submitted by Uli Schlachter on March 30, 2018, 7:25 a.m.

Details

Message ID 20180330072528.27325-1-psychon@znc.in
State New
Series "Skip font-variations test for missing fonts"
Headers show

Commit Message

Uli Schlachter March 30, 2018, 7:25 a.m.
Signed-off-by: Uli Schlachter <psychon@znc.in>
---
 test/font-variations.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/test/font-variations.c b/test/font-variations.c
index 204a29743..7913701b5 100644
--- a/test/font-variations.c
+++ b/test/font-variations.c
@@ -105,7 +105,7 @@  test_variation (cairo_test_context_t *ctx,
     }
     if (strcmp (ft_face->family_name, "Adobe Variable Font Prototype") != 0) {
         cairo_test_log (ctx, "This test requires the font \"Adobe Variable Font Prototype\" (https://github.com/adobe-fonts/adobe-variable-font-prototype/releases)");
-        return CAIRO_TEST_FAILURE;
+        return CAIRO_TEST_UNTESTED;
     }
 
     ret = FT_Get_MM_Var (ft_face, &ft_mm_var);

Comments

Bryce Harrington April 2, 2018, 6:10 p.m.
Confirmed test suite is broken without this due to variable fonts work,
and fixed by this change.

Reviewed-by: Bryce Harrington <bryce@osg.samsung.com>

Landed and pushed:
To ssh://git.freedesktop.org/git/cairo
   1ed124a..fba7a7c  master -> master


On Fri, Mar 30, 2018 at 09:25:28AM +0200, Uli Schlachter wrote:
> Signed-off-by: Uli Schlachter <psychon@znc.in>
> ---
>  test/font-variations.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/font-variations.c b/test/font-variations.c
> index 204a29743..7913701b5 100644
> --- a/test/font-variations.c
> +++ b/test/font-variations.c
> @@ -105,7 +105,7 @@ test_variation (cairo_test_context_t *ctx,
>      }
>      if (strcmp (ft_face->family_name, "Adobe Variable Font Prototype") != 0) {
>          cairo_test_log (ctx, "This test requires the font \"Adobe Variable Font Prototype\" (https://github.com/adobe-fonts/adobe-variable-font-prototype/releases)");
> -        return CAIRO_TEST_FAILURE;
> +        return CAIRO_TEST_UNTESTED;
>      }
>  
>      ret = FT_Get_MM_Var (ft_face, &ft_mm_var);
> -- 
> 2.16.2
> 
> -- 
> cairo mailing list
> cairo@cairographics.org
> https://lists.cairographics.org/mailman/listinfo/cairo