drm/i915: warn only once about ddi translation table missing

Submitted by Michel Thierry on March 28, 2018, 9:03 p.m.

Details

Message ID 20180328210304.20031-1-michel.thierry@intel.com
State New
Headers show
Series "drm/i915: warn only once about ddi translation table missing" ( rev: 1 ) in Intel GFX

Not browsing as part of any series.

Commit Message

Michel Thierry March 28, 2018, 9:03 p.m.
It's not like it will magically appear or disappear ;)

Signed-off-by: Michel Thierry <michel.thierry@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_ddi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index a6672a9abd85..1558eeb13b80 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -892,7 +892,7 @@  static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port por
 		intel_ddi_get_buf_trans_hdmi(dev_priv, &n_entries);
 		default_entry = 6;
 	} else {
-		WARN(1, "ddi translation table missing\n");
+		WARN_ONCE(1, "ddi translation table missing\n");
 		return 0;
 	}
 

Comments

Quoting Michel Thierry (2018-03-28 22:03:04)
> It's not like it will magically appear or disappear ;)

You know the quote,
"With an infinite amount of spam, we get Shakespeare."
-Chris
On Wed, Mar 28, 2018 at 02:03:04PM -0700, Michel Thierry wrote:
> It's not like it will magically appear or disappear ;)
> 
> Signed-off-by: Michel Thierry <michel.thierry@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>

Not sure why someone keeps using a driver that doesn't support the
hw they have ;)

Anyways,
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index a6672a9abd85..1558eeb13b80 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -892,7 +892,7 @@ static int intel_ddi_hdmi_level(struct drm_i915_private *dev_priv, enum port por
>  		intel_ddi_get_buf_trans_hdmi(dev_priv, &n_entries);
>  		default_entry = 6;
>  	} else {
> -		WARN(1, "ddi translation table missing\n");
> +		WARN_ONCE(1, "ddi translation table missing\n");
>  		return 0;
>  	}
>  
> -- 
> 2.16.2