[v2] Revert "drm/i915/gvt: set max priority for gvt context"

Submitted by Weinan Li on March 21, 2018, 7:40 a.m.

Details

Message ID 1521618032-3088-1-git-send-email-weinan.z.li@intel.com
State New
Headers show
Series "Revert "drm/i915/gvt: set max priority for gvt context"" ( rev: 2 ) in Intel GVT devel

Not browsing as part of any series.

Commit Message

Weinan Li March 21, 2018, 7:40 a.m.
This reverts commit 11474e9091cf2002e948647fd9f63a7f027e488a.

There are issues which will block the host preemption before, instead of
disabling it use one workaround "setting max priority for gvt context"
to avoid the gvt context be preempted by the host. Now the issues have been
cleared, so revert this patch to enable host preemption.

v2:
- refine description(Zhenyu)

Signed-off-by: Weinan Li <weinan.z.li@intel.com>
---
 drivers/gpu/drm/i915/gvt/scheduler.c | 3 ---
 1 file changed, 3 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/gvt/scheduler.c
index 638abe8..d71e3de 100644
--- a/drivers/gpu/drm/i915/gvt/scheduler.c
+++ b/drivers/gpu/drm/i915/gvt/scheduler.c
@@ -1134,9 +1134,6 @@  int intel_vgpu_setup_submission(struct intel_vgpu *vgpu)
 	if (IS_ERR(s->shadow_ctx))
 		return PTR_ERR(s->shadow_ctx);
 
-	if (HAS_LOGICAL_RING_PREEMPTION(vgpu->gvt->dev_priv))
-		s->shadow_ctx->priority = INT_MAX;
-
 	bitmap_zero(s->shadow_ctx_desc_updated, I915_NUM_ENGINES);
 
 	s->workloads = kmem_cache_create_usercopy("gvt-g_vgpu_workload",

Comments

On 2018.03.21 15:40:32 +0800, Weinan Li wrote:
> This reverts commit 11474e9091cf2002e948647fd9f63a7f027e488a.
> 
> There are issues which will block the host preemption before, instead of
> disabling it use one workaround "setting max priority for gvt context"
> to avoid the gvt context be preempted by the host. Now the issues have been
> cleared, so revert this patch to enable host preemption.
> 
> v2:
> - refine description(Zhenyu)
> 
> Signed-off-by: Weinan Li <weinan.z.li@intel.com>
> ---
>  drivers/gpu/drm/i915/gvt/scheduler.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/gvt/scheduler.c
> index 638abe8..d71e3de 100644
> --- a/drivers/gpu/drm/i915/gvt/scheduler.c
> +++ b/drivers/gpu/drm/i915/gvt/scheduler.c
> @@ -1134,9 +1134,6 @@ int intel_vgpu_setup_submission(struct intel_vgpu *vgpu)
>  	if (IS_ERR(s->shadow_ctx))
>  		return PTR_ERR(s->shadow_ctx);
>  
> -	if (HAS_LOGICAL_RING_PREEMPTION(vgpu->gvt->dev_priv))
> -		s->shadow_ctx->priority = INT_MAX;
> -
>  	bitmap_zero(s->shadow_ctx_desc_updated, I915_NUM_ENGINES);
>  
>  	s->workloads = kmem_cache_create_usercopy("gvt-g_vgpu_workload",
> -- 

applied, thanks!