[Mesa-dev] mesa: fix make check for ARB_buffer_storage

Submitted by Marek Olšák on Feb. 25, 2014, 10:20 p.m.

Details

Message ID 1393366846-24030-1-git-send-email-maraeo@gmail.com
State New
Headers show

Not browsing as part of any series.

Commit Message

Marek Olšák Feb. 25, 2014, 10:20 p.m.
From: Marek Olšák <marek.olsak@amd.com>

---
 src/mesa/main/tests/dispatch_sanity.cpp | 3 +++
 1 file changed, 3 insertions(+)

Patch hide | download patch | download mbox

diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_sanity.cpp
index 117a570..dbcd4ab 100644
--- a/src/mesa/main/tests/dispatch_sanity.cpp
+++ b/src/mesa/main/tests/dispatch_sanity.cpp
@@ -933,6 +933,9 @@  const struct function gl_core_functions_possible[] = {
    { "glVDPAUMapSurfacesNV", 11, -1 },
    { "glVDPAUUnmapSurfacesNV", 11, -1 },
 
+   /* GL_ARB_buffer_storage */
+   { "glBufferStorage", 11, -1 },
+
    { NULL, 0, -1 }
 };
 

Comments

Seems oddly reminiscent of
http://cgit.freedesktop.org/mesa/mesa/commit/?id=f094866d93b772cc91844e012ad07ce4a78fda5d
(although that change had 43 instead of 11 -- i guess that's the gl
version?)

On Tue, Feb 25, 2014 at 5:20 PM, Marek Olšák <maraeo@gmail.com> wrote:
> From: Marek Olšák <marek.olsak@amd.com>
>
> ---
>  src/mesa/main/tests/dispatch_sanity.cpp | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_sanity.cpp
> index 117a570..dbcd4ab 100644
> --- a/src/mesa/main/tests/dispatch_sanity.cpp
> +++ b/src/mesa/main/tests/dispatch_sanity.cpp
> @@ -933,6 +933,9 @@ const struct function gl_core_functions_possible[] = {
>     { "glVDPAUMapSurfacesNV", 11, -1 },
>     { "glVDPAUUnmapSurfacesNV", 11, -1 },
>
> +   /* GL_ARB_buffer_storage */
> +   { "glBufferStorage", 11, -1 },
> +
>     { NULL, 0, -1 }
>  };
>
> --
> 1.8.3.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
It's actually an extension, so it should be available with any
version. I don't know. This is the first time I'm modifying the test.

Marek

On Tue, Feb 25, 2014 at 11:34 PM, Ilia Mirkin <imirkin@alum.mit.edu> wrote:
> Seems oddly reminiscent of
> http://cgit.freedesktop.org/mesa/mesa/commit/?id=f094866d93b772cc91844e012ad07ce4a78fda5d
> (although that change had 43 instead of 11 -- i guess that's the gl
> version?)
>
> On Tue, Feb 25, 2014 at 5:20 PM, Marek Olšák <maraeo@gmail.com> wrote:
>> From: Marek Olšák <marek.olsak@amd.com>
>>
>> ---
>>  src/mesa/main/tests/dispatch_sanity.cpp | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_sanity.cpp
>> index 117a570..dbcd4ab 100644
>> --- a/src/mesa/main/tests/dispatch_sanity.cpp
>> +++ b/src/mesa/main/tests/dispatch_sanity.cpp
>> @@ -933,6 +933,9 @@ const struct function gl_core_functions_possible[] = {
>>     { "glVDPAUMapSurfacesNV", 11, -1 },
>>     { "glVDPAUUnmapSurfacesNV", 11, -1 },
>>
>> +   /* GL_ARB_buffer_storage */
>> +   { "glBufferStorage", 11, -1 },
>> +
>>     { NULL, 0, -1 }
>>  };
>>
>> --
>> 1.8.3.2
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Vinson already beat you to the identical patch:  f094866.

On 02/25/2014 02:20 PM, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak@amd.com>
>
> ---
>   src/mesa/main/tests/dispatch_sanity.cpp | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_sanity.cpp
> index 117a570..dbcd4ab 100644
> --- a/src/mesa/main/tests/dispatch_sanity.cpp
> +++ b/src/mesa/main/tests/dispatch_sanity.cpp
> @@ -933,6 +933,9 @@ const struct function gl_core_functions_possible[] = {
>      { "glVDPAUMapSurfacesNV", 11, -1 },
>      { "glVDPAUUnmapSurfacesNV", 11, -1 },
>
> +   /* GL_ARB_buffer_storage */
> +   { "glBufferStorage", 11, -1 },
> +
>      { NULL, 0, -1 }
>   };
>
>