[libxcb,1/7] autoconf: disable -Wcast-qual warnings

Submitted by Ran Benita on Feb. 23, 2014, 8:55 p.m.

Details

Message ID 1393188921-19614-2-git-send-email-ran234@gmail.com
State Rejected
Headers show

Not browsing as part of any series.

Commit Message

Ran Benita Feb. 23, 2014, 8:55 p.m.
Both the core code and the generated code spew huge amounts of this
warning. None of them point to a real issue, so just disable it.

Signed-off-by: Ran Benita <ran234@gmail.com>
---
 configure.ac | 2 ++
 1 file changed, 2 insertions(+)

Patch hide | download patch | download mbox

diff --git a/configure.ac b/configure.ac
index 68c3b2f..e6ca02d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -31,6 +31,8 @@  XORG_DEFAULT_OPTIONS
 XORG_ENABLE_DEVEL_DOCS
 XORG_WITH_DOXYGEN
 
+XORG_TESTSET_CFLAG([BASE_CFLAGS], [-Wno-cast-qual])
+
 # The dot drawing tool is checked by XORG_WITH_DOXYGEN, needed for xcb manual
 if test x"$HAVE_DOT" = xno; then
     AC_MSG_WARN([dot not found - doxygen targets will be skipped])

Comments

On 14-02-23 03:55 PM, Ran Benita wrote:
> +XORG_TESTSET_CFLAG([BASE_CFLAGS], [-Wno-cast-qual])
This one has been placed in the penalty box in
util/macros/xorg-macros.m4.in. It is likely to remain there forever.

You need util-macros package version 1.18 minimum.
On Sun, Feb 23, 2014 at 05:36:00PM -0500, Gaetan Nadon wrote:
> On 14-02-23 03:55 PM, Ran Benita wrote:
> > +XORG_TESTSET_CFLAG([BASE_CFLAGS], [-Wno-cast-qual])
> This one has been placed in the penalty box in
> util/macros/xorg-macros.m4.in. It is likely to remain there forever.

Indeed, great.

> You need util-macros package version 1.18 minimum.

Maybe I didn't regenerate the first time? In any case, thanks!

Ran