drm/i915: Wedged engine mask makes more sense in hex

Submitted by Tvrtko Ursulin on Feb. 28, 2018, 5:18 p.m.

Details

Message ID 20180228171844.20006-1-tvrtko.ursulin@linux.intel.com
State Accepted
Commit c27557ab56bc943c59ea353bfcb6fc37a6f7b728
Headers show
Series "drm/i915: Wedged engine mask makes more sense in hex" ( rev: 1 ) in Intel GFX

Browsing this patch as part of:
"drm/i915: Wedged engine mask makes more sense in hex" rev 1 in Intel GFX
<< prev patch [1/1] next patch >>

Commit Message

Tvrtko Ursulin Feb. 28, 2018, 5:18 p.m.
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

In decimal its just a weird big number, while in hex can actually log
which engines were requested to be wedged.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/i915_debugfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 472240349388..2a4c258b90fd 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -3977,7 +3977,8 @@  i915_wedged_set(void *data, u64 val)
 		engine->hangcheck.stalled = true;
 	}
 
-	i915_handle_error(i915, val, "Manually setting wedged to %llu", val);
+	i915_handle_error(i915, val, "Manually set wedged engine mask = %llx",
+			  val);
 
 	wait_on_bit(&i915->gpu_error.flags,
 		    I915_RESET_HANDOFF,

Comments

On 28/02/18 09:18, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> In decimal its just a weird big number, while in hex can actually log
> which engines were requested to be wedged.
> 

And IGT is not reading the hang reason in this case, so


Reviewed-by: Michel Thierry <michel.thierry@intel.com>

> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>   drivers/gpu/drm/i915/i915_debugfs.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 472240349388..2a4c258b90fd 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -3977,7 +3977,8 @@ i915_wedged_set(void *data, u64 val)
>   		engine->hangcheck.stalled = true;
>   	}
>   
> -	i915_handle_error(i915, val, "Manually setting wedged to %llu", val);
> +	i915_handle_error(i915, val, "Manually set wedged engine mask = %llx",
> +			  val);
>   
>   	wait_on_bit(&i915->gpu_error.flags,
>   		    I915_RESET_HANDOFF,
>
Quoting Tvrtko Ursulin (2018-02-28 17:18:44)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> In decimal its just a weird big number, while in hex can actually log
> which engines were requested to be wedged.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Oh, and another thing that bugs me, is "action: reset". That's all we
say, and I think it's immaterial to the post-mortem error state. Just
creates extra work for me in removing that useless bit of information
when it gets cut and pasted into bug reports.
-Chris