[xserver] mi: Mention extension loading in verbose logs

Submitted by Emil Velikov on Feb. 21, 2018, 5:12 p.m.

Details

Message ID 20180221171215.7433-1-emil.l.velikov@gmail.com
State Accepted
Commit ac13d740bf14ba8799d4dfbee1f6f99a297dbc7e
Headers show
Series "mi: Mention extension loading in verbose logs" ( rev: 1 ) in X.org (DEPRECATED - USE GITLAB)

Not browsing as part of any series.

Commit Message

Emil Velikov Feb. 21, 2018, 5:12 p.m. 
From: Emil Velikov <emil.velikov@collabora.com>

Listing the extensions is useful, despite being annoying for normal
usecases. Print it only when extra (lvl 3) vebose is requested.

v2: Move the logging to InitExtensions(), as requested by Adam.

Cc: Adam Jackson <ajax@nwnk.net>
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
---
 mi/miinitext.c | 4 ++++
 1 file changed, 4 insertions(+)

Patch hide | download patch | download mbox 

diff --git a/mi/miinitext.c b/mi/miinitext.c
index e55073bf3..5596e212f 100644
--- a/mi/miinitext.c
+++ b/mi/miinitext.c
@@ -104,6 +104,7 @@  SOFTWARE.
 #include "nonsdk_extinit.h"
 #endif
 #include "micmap.h"
+#include "os.h"
 #include "globals.h"
 
 /* List of built-in (statically linked) extensions */
@@ -260,6 +261,9 @@  InitExtensions(int argc, char *argv[])
         ext = &ExtensionModuleList[i];
         if (ext->initFunc != NULL &&
             (ext->disablePtr == NULL || !*ext->disablePtr)) {
+            LogMessageVerb(X_INFO, 3, "Initializing extension %s\n",
+                           ext->name);
+
             (ext->initFunc) ();
         }
     }

Comments

Adam Jackson Feb. 21, 2018, 6:25 p.m. 
On Wed, 2018-02-21 at 17:12 +0000, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov@collabora.com>
> 
> Listing the extensions is useful, despite being annoying for normal
> usecases. Print it only when extra (lvl 3) vebose is requested.
> 
> v2: Move the logging to InitExtensions(), as requested by Adam.

Merged, thanks:

remote: I: patch #205981 updated using rev ac13d740bf14ba8799d4dfbee1f6f99a297dbc7e.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   9237c5e28..ac13d740b  master -> master

- ajax