[09/17] Reorder headers according to style guide

Submitted by Christophe de Dinechin on Feb. 16, 2018, 4:15 p.m.

Details

Message ID 20180216161547.28110-10-christophe@dinechin.org
State New
Headers show
Series "WIP: Refactor the streaming agent towards a more standard C++ style" ( rev: 1 ) in Spice

Not browsing as part of any series.

Commit Message

Christophe de Dinechin Feb. 16, 2018, 4:15 p.m.
From: Christophe de Dinechin <dinechin@redhat.com>

Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
---
 src/spice-streaming-agent.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index 720173a..f845bd0 100644
--- a/src/spice-streaming-agent.cpp
+++ b/src/spice-streaming-agent.cpp
@@ -4,6 +4,9 @@ 
  * Copyright 2016-2017 Red Hat Inc. All rights reserved.
  */
 
+#include "concrete-agent.hpp"
+#include "hexdump.h"
+
 #include <stdio.h>
 #include <stdlib.h>
 #include <stdint.h>
@@ -34,8 +37,7 @@ 
 #include <spice-streaming-agent/frame-capture.hpp>
 #include <spice-streaming-agent/plugin.hpp>
 
-#include "hexdump.h"
-#include "concrete-agent.hpp"
+
 
 using namespace spice::streaming_agent;
 

Comments

On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote:
> From: Christophe de Dinechin <dinechin@redhat.com>
> 
> Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
> ---
>  src/spice-streaming-agent.cpp | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
> index 720173a..f845bd0 100644
> --- a/src/spice-streaming-agent.cpp
> +++ b/src/spice-streaming-agent.cpp
> @@ -4,6 +4,9 @@
>   * Copyright 2016-2017 Red Hat Inc. All rights reserved.
>   */
>  
> +#include "concrete-agent.hpp"
> +#include "hexdump.h"
> +
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <stdint.h>
> @@ -34,8 +37,7 @@
>  #include <spice-streaming-agent/frame-capture.hpp>
>  #include <spice-streaming-agent/plugin.hpp>
>  
> -#include "hexdump.h"
> -#include "concrete-agent.hpp"
> +
>  
>  using namespace spice::streaming_agent;

While at it, I would also move the spice installed headers up. Can help
to catch issues with them. I've got a patch where I also separate the
system and C++ headers and order them alphabetically, but you don't
necessarily need to be that fancy :D

Lukas